feat(event-normalization): Add gen_ai.input.messages and gen_ai.output.messages as distinct fields for SpanData#5797
Merged
constantinius merged 5 commits intomasterfrom Apr 8, 2026
Conversation
…tput.messages` as distinct fields for SpanData
constantinius
changed the title
gen_ai.input.messages and gen_ai.output.messages as distinct fields for SpanDatagen_ai.input.messages and gen_ai.output.messages as distinct fields for SpanData
jjbayer
reviewed
Apr 8, 2026
Comment on lines
+703
to
+709
| /// The input messages to the model call. | ||
| #[metastructure(field = "gen_ai.input.messages", pii = "maybe")] | ||
| pub gen_ai_input_messages: Annotated<Value>, | ||
|
|
||
| /// The output messages from the model call. | ||
| #[metastructure(field = "gen_ai.output.messages", pii = "maybe")] | ||
| pub gen_ai_output_messages: Annotated<Value>, |
Member
There was a problem hiding this comment.
You'll also want to add getters to impl Getter for SpanData below.
Member
There was a problem hiding this comment.
JFYI it's similar to what was done in this PR: #5788
Contributor
Author
There was a problem hiding this comment.
Good catch, thanks!
loewenheim
approved these changes
Apr 8, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 28ec890. Configure here.
constantinius
deleted the
constantinius/feat/event-schema/gen-ai-input-output-messages
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to https://linear.app/getsentry/issue/TET-2188/mark-gen-aiinputmessages-as-pii-maybe