fix(dashboard): escape author field in revision table#1001
Merged
Conversation
The author column in `dashboard revisions` output wasn't wrapped with `escapeMarkdownCell()`, so names/emails containing `|` would break the markdown table rendering.
Contributor
|
Contributor
Codecov Results 📊✅ Patch coverage is 100.00%. Project has 4287 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 81.64% 81.64% —%
==========================================
Files 328 328 —
Lines 23344 23344 —
Branches 15111 15111 —
==========================================
+ Hits 19058 19057 -1
- Misses 4286 4287 +1
- Partials 1613 1613 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
authorcolumn indashboard revisionswithescapeMarkdownCell()to prevent markdown table breakage when a user's name or email contains|One-line change, no new dependencies.