Repository navigation
docs(issues): ISSUE-701 accepts tags backed by immutable releases - #497
Merged
Merged
Conversation
getplumber/plumber#567 accepts a tag whose GitHub release is immutable as pinned, for steps and reusable workflows. Only the exact released tag qualifies; floating majors, mutable releases, branches and a tag shadowed by a same-named branch are still reported, and without a token (or when the release cannot be read) the reference is reported. - ISSUE-701 page: description, remediation and a first tip on the exemption, its token requirement and immutableReleaseRefs. - Control catalog line and controls configuration section. - Plumber Score sample report: immutableReleaseRefs and actionRefsImmutableRelease in actionPinningResult. - GitHub CLI troubleshooting: why an immutable tag can still be reported.
|
Preview deployment for 1d785cd: https://getplumber-h5z3ibpkj-getplumber.vercel.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
docs
What this PR does / why we need it:
Documents the ISSUE-701 change in getplumber/plumber#567. A tag backed by an immutable GitHub release now counts as pinned, for step actions and reusable-workflow calls. Only the exact released tag qualifies. Still reported:
@v4(no release behind them);The check fails closed: without a token, or when the release cannot be read, the reference is reported.
src/data/issues.ts):docker/build-push-action@v7.4.0yes,@v7no), the shadowing branch, the API call and token requirement, fail-closed, and theactionPinningResult.immutableReleaseRefslist withpinnedVia: immutable_release.controlCatalog.actionsMustBePinnedByCommitSha): one sentence on the exemption./docs/cli/controls-configuration#actionsmustbepinnedbycommitsha): a paragraph on the exemption and the token it needs.immutableReleaseRefsandmetrics.actionRefsImmutableReleaseadded to theactionPinningResultsample, matching the new report shape.Which issue(s) this PR is related to:
getplumber/plumber#421, getplumber/plumber#567
Special notes for your reviewer:
Merge after getplumber/plumber#567 ships in a CLI release, so the pages don't describe behavior the published CLI doesn't have yet.
How was this tested?
docker/build-push-action@v7.4.0,golangci/golangci-lint-action@v9.3.0and adocker/github-builderreusable workflow accepted;@v7,@master, a mutable release and@v1still reported; everything reported again with the GitHub API disabled).src/data/issues.tsparses (TypeScript syntax check). No em dashes in the new copy.AI usage disclosure:
YES. Written with Claude Code from the #567 implementation, then reviewed by the author.
🤖 Generated with Claude Code