Skip to content

Add Korean UI localization - #2895

Merged
boudra merged 3 commits into
getpaseo:mainfrom
himomohi:agent/add-korean-localization
Aug 5, 2026
Merged

boudra merged 3 commits into
getpaseo:mainfrom
himomohi:agent/add-korean-localization

Conversation

@himomohi

@himomohi himomohi commented Aug 5, 2026 •

Copy link
Copy Markdown
Contributor

What

Adds Korean (ko) as a supported client UI locale on the current main branch.

  • adds a complete Korean resource with parity against all 1,603 English UI keys
  • adds 한국어 to the language selector and language-name matrix
  • resolves ko, ko-KR, and other ko-* system locales to Korean
  • registers the Korean bundle in the shared Expo client used by iOS, Android, web, and Electron
  • adds locale, resource-parity, interpolation, and browser language-switch coverage
  • updates the i18n documentation

Why

Korean is still absent from the current language options, so Korean system locales fall back to English. This refreshes the work from #1544 against the latest client translation surface.

The Korean translation from #1544 was used as the baseline and updated for the current 1,603-key resource. Original contributor @Kesta-bos is preserved as a co-author on the commit.

Verification

  • npx vitest run packages/app/src/i18n/locales.test.ts packages/app/src/i18n/resources.test.ts packages/app/src/i18n/sync-language.test.ts packages/app/src/i18n/init.test.ts --bail=1
    • 4 files, 52 tests passed
  • npm run typecheck
    • passed across all workspaces
  • npm run lint
    • 0 warnings, 0 errors
  • npm run format:check
    • passed
  • npm run test:e2e --workspace=@getpaseo/app -- e2e/browser/settings-i18n.spec.ts
    • 2 browser tests passed, including English → Korean → English
  • iOS Expo/Hermes export
    • passed; 25.9 MB iOS bundle generated
  • Android Expo/Hermes export
    • passed; 25.9 MB Android bundle generated

Platform coverage

Platform Evidence
Web Playwright language-switch flow passed
iOS Expo/Hermes bundle generated; simulator/device not available
Android Expo/Hermes bundle generated; emulator/device not available
Electron Shared client typecheck passed; desktop runtime not manually exercised

No protocol or daemon behavior changes are included.

Refreshes the Korean translation from getpaseo#1544 against the current client locale surface and adds cross-platform locale detection coverage.\n\nCo-authored-by: JinHyeok Jeong <150323322+Kesta-bos@users.noreply.github.com>
@greptile-apps

greptile-apps Bot commented Aug 5, 2026 •

Copy link
Copy Markdown
Contributor

Greptile Summary

Adds Korean as a supported UI locale across the shared Expo client.

  • Registers the complete Korean translation resource and adds Korean to language selectors.
  • Resolves ko and regional ko-* system locales to Korean.
  • Adds resource-parity, interpolation, locale-resolution, and browser language-switch coverage.
  • Updates the i18n documentation.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
packages/app/src/i18n/resources/ko.ts Adds the complete Korean translation resource with the same typed key surface as English.
packages/app/src/i18n/locales.ts Registers Korean in locale types, selector metadata, language-name mappings, and system-locale resolution.
packages/app/src/i18n/i18next.ts Registers the Korean resource bundle with the shared i18next client initialization.
packages/app/src/i18n/resources.test.ts Extends translation parity and interpolation checks to the Korean resource.
packages/app/e2e/browser/settings-i18n.spec.ts Covers switching from English to Korean and back through the browser settings UI.
docs/i18n.md Documents Korean support, system-locale mapping, and the new localization batch.

Reviews (3): Last reviewed commit: "Merge remote-tracking branch 'origin/mai..." | Re-trigger Greptile

@myung-nyun

Copy link
Copy Markdown

벌써 한국분께서 요청하셨군요!

boudra and others added 2 commits August 5, 2026 20:15
Restore the wording corrections contributed in the original Korean localization work and lock them with exact-copy assertions.

Co-authored-by: JinHyeok Jeong <150323322+Kesta-bos@users.noreply.github.com>
@boudra
boudra merged commit 0728148 into getpaseo:main Aug 5, 2026
24 checks passed
lzm04521 pushed a commit to lzm04521/paseo that referenced this pull request Aug 12, 2026
* Add Korean UI localization

Refreshes the Korean translation from getpaseo#1544 against the current client locale surface and adds cross-platform locale detection coverage.\n\nCo-authored-by: JinHyeok Jeong <150323322+Kesta-bos@users.noreply.github.com>

* fix(i18n): preserve reviewed Korean status labels

Restore the wording corrections contributed in the original Korean localization work and lock them with exact-copy assertions.

Co-authored-by: JinHyeok Jeong <150323322+Kesta-bos@users.noreply.github.com>

---------

Co-authored-by: Mohamed Boudra <boudra.moha@gmail.com>
Co-authored-by: JinHyeok Jeong <150323322+Kesta-bos@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants