Repository navigation
feat(agent): region tools set and read every zoom, annotation and audio setting - #1182
Merged
Merged
Conversation
…io setting setZoom/addZoom take focusMode, hideCursor and customScale (written as the inspector writes a typed level, refused past the clip's zoomScaleLimit). add/setAnnotation take the type (text, arrow, privacy blur) through convertAnnotationKind, with figureData/blurData validated by the schema's own. add/setAudio take fades capped at the inspector's AUDIO_FADE_MAX_MS. getCurrentDocument reads all of it back. Part of #1180
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description check |  |
The description is complete and matches the template. It summarizes the feature, links the related issue, identifies the change type and release impact, states desktop impact, explains why screenshots… |
| Title check | |
The title clearly identifies the main change: region tools can set and read zoom, annotation, and audio settings. |
| Docstring Coverage | |
Docstring coverage is 94.12% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 17 functions across 9 files. (10 skipped: 1… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Batch C of #1180: the region tools reach every setting the inspector has, and
getCurrentDocumentreads them back. Both transports get it (shared tool table), the in-app chat agent too.Zooms (
addZoom(s),setZoom)focusMode(manual / auto) andhideCursor, written as the inspector writes them.customScale: rounded to the hundredth and stored as a depth when the table has that level (zoomLevelFor, now shared with the inspector's level control). Refused past the clip'szoomScaleLimit, with the limit in the message, as the inspector refuses it.depthwithcustomScaleis refused.Annotations (
addAnnotation,setAnnotation)type: text, arrow (figure) or privacyblur, converted throughconvertAnnotationKind. A retype uses the footage under each fragment (annotationFootageRect), like the type switch.figureData/blurDatavalidated by the schema'sfigureDataSchema/blurDataSchema(now exported). OnsetAnnotationonly the keys sent change.width/heightfor arrows and blurs. A blur's box is the recording's picture, so it stays on what it hides.Audio (
addAudio,setAudio)fadeInMs/fadeOutMs, capped atAUDIO_FADE_MAX_MS(5000), moved out ofRightPanes.tsxso the pane and the tools share it.Read side
box(frame / footage), centrex/y,width/height, a text's look, an arrow'sfigureData, a blur'sblurData. An image no longer dumps its data URL astext.hideCursorwhen set (customScalewas already there). Each audio track: its fades.Product decisions
addAudiokeeps fades at 0 by default, as before. The editor's music defaults (−18 dB, 1 s fades) are not applied to agent tracks.Docs: tool descriptions, system prompt,
ai-agent.md,website/docs/ai-editing.mdand its 7 translations, theopenscreen-demoskill.mcp-server.mdneeded no change: it lists no per-tool arguments.Related issue
Part of #1180
Type of change
Release impact
Desktop impact
Screenshots / video
None: no UI change. The inspector's level control and audio pane behave as before.
Testing
electron/ai-edition/agent-tools.test.ts(zoom settings, level limit, blur, arrow, retype, refusals, fades) anddeep-agent/service.test.ts(descriptions).npx tsc --noEmit,npx tsc -p tsconfig.test.json --noEmit,npm run lint.npx vitest --run electron/ai-edition electron/mcp src/lib/ai-edition: 1746 passed.🤖 Generated with Claude Code
Summary by CodeRabbit