Repository navigation
S3: return ListPartsResult as the ListParts XML root - #10571
Open
tonypottera24 wants to merge 1 commit into
Open
tonypottera24 wants to merge 1 commit into
tonypottera24 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ListPartscurrently returns HTTP 200 with aListPartsResponseXML root. S3 requiresListPartsResult. AWS SDK for Rust 1.154.0 rejects the unexpected root and surfaces an unhandled service error without a modeled error code or message, even for an empty multipart upload. Boto3 accepts the response, so assertions on its parsed result do not catch the mismatch.Add the existing model-extra
resultWrappersetting forListParts, following the approach used forCompleteMultipartUploadin #10056. Extend the existing multipart-list test to inspect the raw XML on everyListPartsresponse; its existing scenarios cover empty uploads, uploaded parts and pagination. Storage, authorization, error responses and the shared serializer are unchanged.Validation on Python 3.12.3:
ListPartsResponse.make lintpasses (ruff 0.14.10, formatting and mypy).pytest -q tests/test_s3 tests/test_core/test_serialize.py tests/test_core/test_response_serialization.py— 584 passed, 5 skipped, 2 xfailed.These are local Moto tests; no real AWS requests were made.