Repository navigation
Kinesis: honor ExclusiveStartShardId in DescribeStream - #10568
Open
gedaliakliger wants to merge 1 commit into
Open
gedaliakliger wants to merge 1 commit into
gedaliakliger wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10567
DescribeStreamappliedLimitand setHasMoreShards, but ignoredExclusiveStartShardId, so each follow-up call returned the first page again, and botocore'sdescribe_streampaginator raisedPaginationErrorwheneverPageSizewas below the shard count.describe_streamnow passesExclusiveStartShardIdtoStream.to_json, which starts after that shard ID (IDs are zero-padded, so string order is ID order) and computesHasMoreShardsfrom the shards left after it. Calls without the parameter return what they did before.test_describe_stream_exclusive_start_shard_idpages a five-shard stream by hand (shards 2 and 3 withHasMoreShardstrue, then shard 4 with it false) and through the paginator withPageSize=2(all five shards once, in order). It fails onmasterand passes with the fix.Ran here:
tests/test_kinesis/(89 passed, Docker tests skipped), the new test andtest_describe_stream_limit_parameterin server mode, andruff format,ruff checkandmypyon the changed files. The full suites are left to CI.AWS reference: https://docs.aws.amazon.com/kinesis/latest/APIReference/API_DescribeStream.html