Repository navigation
Logs: resolve the requested log group identifier - #10549
Open
narayana006 wants to merge 1 commit into
Open
narayana006 wants to merge 1 commit into
narayana006 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CloudWatch Logs: resolve the requested log group identifier
DescribeLogStreams(logGroupIdentifier=) currently returns streams from the last-created group. An unknown identifier can likewise select an unrelated group instead of raising ResourceNotFoundException. The lookup loop overwrites its result on every iteration and never stops on a match.
Resolve names directly and stop at the matching ARN. Leave unmatched identifiers unresolved so the existing ResourceNotFoundException path runs. Six regression cases cover correct and missing names/ARNs through DescribeLogStreams and GetLogEvents.
Expected behavior follows the DescribeLogStreams API reference.
Validation: all six regression cases fail with the unchanged implementation and pass after the fix. The offline CloudWatch Logs suite passes: 132 passed, 2 deselected. The two omitted Lambda subscription integration tests require Docker; an initial full run failed on Docker permissions. One unrelated query-time test failed once and passed on unchanged code and on the final run. Repository-wide Ruff checks and formatting, targeted mypy for moto/logs/models.py, and git diff --check pass. No real AWS verification or full-project mypy is claimed.
Prepared with OpenAI Codex assistance.