Repository navigation
EC2: run_instances should launch MaxCount instances - #10533
Open
lechakrawarthy wants to merge 1 commit into
Open
lechakrawarthy wants to merge 1 commit into
lechakrawarthy wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10215
run_instancesonly readMinCountand used it as the instance count, soMinCount=1, MaxCount=3launched a single instance. On AWS the call launches as many instances as capacity allows, up toMaxCount. Moto has no capacity limit, so it now launchesMaxCount(falling back toMinCountifMaxCountis missing).Added
test_run_instances_launches_max_count, which fails on master withassert 1 == 3and passes with this change.Ran locally:
pytest tests/test_ec2 tests/test_autoscaling: 1109 passedruff check moto testsandruff format --check: clean