Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetLaunchTemplateDatacurrently replaces every block-device name with"string"and serializes each network interface's security-group ID as a stringified dictionary (for example,"{'GroupId': 'sg-…'}"). Creating a launch template from the returned data therefore preserves neither the device names nor the security-group IDs of the source instance.Return the existing device-map keys and a list of security-group ID strings. The regression test covers one and two devices/groups and verifies that the exported values survive creating and describing a launch template.
The response shapes follow the AWS references for block device mappings and network interface groups.
Validation (Python 3.12, locally mocked AWS):
pytest -q tests/test_ec2/test_launch_templates.py: 37 passed.pytest -q tests/test_ec2/test_instances.py tests/test_ec2/test_elastic_network_interfaces.py: 157 passed.git diff --checkpasses.No live AWS verification was performed. OpenAI Codex assisted with the implementation and local validation.