feat: declare script globals as an array of {path, name} tables - #246
Merged
Conversation
Match mod-utils/hinode's array-of-tables globals convention (Hugo lowercases config keys, so path-keyed global maps break for capitalized bundle filenames). Same window.bootstrap registration, new schema.
Contributor
Author
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the declared script-globals from a path-keyed map to the array-of-tables form
[[...globals]]withpath+name, matching the case-preserving globals convention (Hugo lowercases TOML config keys, so path-keyed maps break for capitalized bundle filenames). This module's bundle name is lowercase so it was never broken, but the convention is moving uniformly across the ecosystem. Same window registration, new schema.Requires
Hinode with the array-of-tables globals reader (v3.10.0+, from hinode#2064). That reader also still accepts the legacy map form, so older hinode keeps working with the prior release of this module.
Verification
Part of the coordinated globals-convention change; proven end-to-end on infusal.io (array-format gsap + map-format modules coexist under the backward-compatible reader).
🤖 Generated with Claude Code