Repository navigation
Don't delay Navie UI until IDE finished indexing - #857
Conversation
dividedmind
left a comment
There was a problem hiding this comment.
Looks good, but is there a potential race here? What if indexing finishes between setupInitMessage() and afterInit()?
3c1d532 to
0d61da3
Compare
|
@dividedmind You're right, this could happen. I've made a change to fix it. |
I'm not sure I understand how the change fixes it. Is the following sequence possible?
|
0d61da3 to
8e1d100
Compare
8e1d100 to
21f1145
Compare
I was too quick when I read your first comment and fixed another possible race, but not the one you mentioned. I started to change the code to install the listener before the data is retrieved. I'd ignore this potential race because the solutions I can think of would make it worse. |
dividedmind
left a comment
There was a problem hiding this comment.
Yeah, you're probably right, this is too much of an edge case to worry about and spend much effort. Just please add a comment about this for posterity.
|
🎉 This PR is included in version 0.78.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Related to #848
Previously, the Navie UI was only shown when the IDE finished indexing.
Especially at startup or when libraries are indexed, this can cause a large delay between opening Navie and the time the Navie UI is displayed.
This PR fixes this problem by detecting dumb mode. Properties are refreshed after the IDE turned into smart mode.