Add support for secrets on windows#74
Merged
Merged
Conversation
emmahoggan
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This adds support for getting and setting secrets on Windows.
We're delegating to the cross-keychain package for the low-level interactions on Windows. Why?
keytarand@github/keytar, but they are both in maintenance modecross-keychainto avoid making a breaking change.handleTemporaryBaseUrlMigration.The change has forced some core functions in
secrets.tsandruntime.tsto becomeasync, which impacts all the commands. So the diff for this change is broad but shallow. There is no change to the existing user experience for MacOS and Linux. In those cases, we're only switching from the blockingexecaSyncfunction to the asyncexecafunction, but the user is waiting for the same work to complete either way.Screenshot of
dx init