Command: workflowRuns trigger#63
Conversation
BigGig17
left a comment
There was a problem hiding this comment.
This looks really good, I don't actually have a lot of concerns around event rendering and approval language for the events per se, however IU do have concerns around the UI Triggering language and how it implies that all triggers are "triggers" and not "requests to trigger" which they sometimes can be.
Additionally, I would like to see the trigger PR split from the rest as I think that's a relatively delicate CLI Item here that I think would value from it's own PR.
Lastly, should we add some in code comments at the top of some of these files to give more of a description of how we intend for them to work or link to the DX Docs for the relevant API Methods perhaps? WDYT?
Also the verify checks seem to be blocking as well 😅
BigGig17
left a comment
There was a problem hiding this comment.
one more minor tweak but otherwise I like it!
This defines the
dx workflowRuns triggercommand.Help text:
Depends on #69. Note that this PR originally had all the other commands but we split off the other PR to define
infoand the event commands.