Skip to content

Send phones the homepage link and close phone download dead ends - #6510

Draft
brsbl wants to merge 1 commit into
mainfrom
phone-share-download-link
Draft

brsbl wants to merge 1 commit into
mainfrom
phone-share-download-link

Conversation

@brsbl

@brsbl brsbl commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

Human comments

What was wrong

On phones, "Send download link" shared whatever page the visitor was on, so the computer could open a guide or plugin page instead of a download. The result of the share wasn't recorded. Guide heroes and the footer still offered Mac installers on phones. "Windows (Alpha)" streamed an .exe to phones. /marketplace and /changelog had no phone install path.

What changed

  • The shared link is now the homepage, which shows the right download for the computer that opens it.
  • The link keeps the page's utm_*, gclid, gbraid and wbraid parameters, and adds a fixed via=share marker.
  • The marker appears in the computer's pageview URL and in the download event's referrer, with no new plumbing.
  • A new landing_send_to_computer_result event records shared, cancelled, copied or copy_failed per placement.
  • On touch devices, guide heroes show "Send download link" instead of "Download for macOS".
  • On touch devices, the footer Download link and the "Windows (Alpha)" link are hidden.
  • /marketplace and /changelog show the send button on touch devices, with new marketplace and changelog placements.
  • Both versions stay in the markup and CSS picks one, so desktop looks the same and phones see no flash.

How you verified

  • New unit tests cover the shared URL, parameter preservation, the marker and the Global Privacy Control case. They pass.
  • New unit tests cover all four result outcomes and the click-to-result event pair. They pass.
  • New render tests check the desktop and touch markup on install options, guide hero, footer and marketplace. They pass.
  • The download endpoint test confirms via=share survives in $referrer.
  • @bb/web tests, typecheck and lint pass locally.
  • No real-device or browser check yet.
  • Remote CI passed on d868db7.

BB-Thread-ID: thr_t5vjqi8ip6

AGENT GENERATED

🤖 Generated with Claude Code

The phone "Send download link" button now shares the homepage with the
page's ad parameters and a fixed via=share marker, and records whether
the share sheet resolved, was cancelled, or fell back to copying.

Guide heroes, /marketplace and /changelog offer the send button on
touch devices. The footer Download link and the Windows (Alpha) link
are hidden on touch. Desktop rendering is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant