Repository navigation
Resolve marketplace Git refs before detached checkout - #5375
Merged
Merged
Conversation
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚨 SLOP COP 🚨 ·
new-issue-autopilotHuman comments
What was wrong
Detached checkout of a short Git branch name triggers Git's implicit local-branch creation when the branch exists only under origin after cloning. Git rejects that combination before BB reads the marketplace manifest. Reproduced on trusted main in two clean checkouts: https://get-bb.github.io/reports/issues/5373.html.
What changed
How you verified
pnpm exec turbo run test --filter=@bb/server -- test/services/plugin-catalog/third-party-marketplaces.test.ts -t 'reads the selected catalog commit'test/services/plugin-catalog, excluding the unrelated official generator suite.pnpm exec turbo run typecheck --filter=@bb/server, focusedoxfmt --check, andgit diff --checkpass; no binary changes.+00:00rather thanZ. The same failure occurs on unchanged trusted main; it does not exercise the modified materializer and is not changed here.Fixes #5373