Repository navigation
Conversation
ymichael
deleted the
bb/acp-permission-changes-cross-provider-permission-thr_5u76q3wzvx
branch
October 5, 2026 18:38
hxy91819
added a commit
to hxy91819/bb
that referenced
this pull request
Oct 12, 2026
Absorbed by desktop-v0.46.0: - fix/acp-permission-mode: upstream get-bb#4922 - fix/sidebar-touch-hover-actions: upstream get-bb#5097 - feature/sidebar-pinned-new-thread: upstream get-bb#5229 nav rail layout - feature/automation-auto-marker: upstream Automation timeline row (get-bb#4763) - fix/mobile-composer-top-clearance: upstream get-bb#5026 - fix/mobile-model-drawer: upstream 8a01b97 Dropped: fix/acp-fast-mode, fix/acp-codex-goal (ACP Codex no longer used); fix/mobile-model-picker folded into fix/provider-icon-hitbox. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
After the runtime delegated permission reconciliation to providers in #1640, ACP retained its launch-time write policy on follow-ups and ignored changed execution options on steers. A thread started in Full could still write outside the workspace after switching to Accept-edits.
What changed
Reconcile ACP permissions before follow-up prompts and steered re-prompts. Update bridge-owned policy in place when launch arguments stay the same; rebuild and use existing session/load support when permission arguments differ. Preserve queued inputs across rebuilds and report failed reconstruction. Keep the unchanged-mode path synchronous to preserve concurrent-start rejection.
Add a shared permission-change contract covering ACP, Codex, and Claude, include Claude’s dependencies in the Windows foundation job’s filtered install, and correct ACP fixtures that accidentally changed modes. No server/daemon wire changes or new public API/CLI surface.
How you verified
@bb/provider-bridge-acpand@bb/provider-bridge-protocol: 367 ACP and 299 protocol tests passed, including 40 permission transitions. Four unrelated ACP operation tests skipped.opencode/fledge-alpha-freethrough the source ACP bridge (model/token provenance confirmed by session export): base reproduces the outside write after tightening; head passes tightening/loosening on follow-ups and active-tool steers. Accept-edits forwards approval, denial leaves the file absent; Full writes the file.--auto, so permission-CLI argument changes, queued steer ordering, and reconstruction failure retain deterministic harness coverage.Real ACP checks invoke the bridge worker directly, not the full BB UI/server/daemon path. Codex/Claude contract adapters use real bridges with provider fakes; native-provider evidence for those unchanged bridges predates this commit. Background tools and Linux sandboxes are outside this verification.
Fixes #4806.
Partially addresses #4797: permission refresh on follow-ups and steers, conditional rebuilds, and session restoration are covered. Its single-logical-turn requirement across native-flag restarts remains outstanding: this implementation emits a cancelled turn boundary and opens a replacement turn. The earlier alternative PR #4795 is closed and was not merged.