Skip to content

Rank keyboard shortcut search by visible label matches - #3924

Merged
SawyerHood merged 1 commit into
get-bb:mainfrom
vznh:fix/shortcut-search-ranking
Sep 19, 2026
Merged

SawyerHood merged 1 commit into
get-bb:mainfrom
vznh:fix/shortcut-search-ranking

Conversation

@vznh

@vznh vznh commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Human comments

Found that some directed queries were generally buried. Found this issue that coincides.

What was wrong

Shortcut search preserved category order, placing description-only matches like “Previous thread” above the direct label match “Toggle sidebar” (#3737).

What changed

Rank results by exact label, label prefix, label substring, command ID, then description, preserving ties across core and plugin commands. Clearing search restores categories; no protocol, CLI, SDK, or configuration changes.

How you verified

  • Two ranking regressions failed before the fix and passed afterward.
  • Focused tests through Turbo: 24 passed, including plugin commands, ties, case/whitespace handling, clearing search, and empty results.
  • App typecheck and lint through Turbo: passed; existing lint warnings remain.
  • Formatting and git diff --check: passed.
  • Live isolated Chromium: “Toggle sidebar” appears first; empty results and category restoration verified.

Fixes #3737.

AGENT GENERATED

@SawyerHood
SawyerHood merged commit 638bef0 into get-bb:main Sep 19, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keyboard shortcut search does not prioritize visible label matches

2 participants