[codex] Fix sidebar new thread empty welcome

apps/app/src/views/RootComposeView.test.ts

@@ -20,6 +20,7 @@ import {
   readInitialPromptFromLocationState,
   resolveRootComposeEffectiveEnvironmentValue,
   resolveRootComposePanelThreadId,
+  shouldStartComposingFromLocationState,
   shouldNavigateAfterThreadCreate,
 } from "./RootComposeView";
 
@@ -255,6 +256,22 @@ describe("hasSingleUseRootComposeTargetState", () => {
   });
 });
 
+describe("shouldStartComposingFromLocationState", () => {
+  it("treats sidebar new-thread focus navigation as a compose request", () => {
+    expect(shouldStartComposingFromLocationState({ focusPrompt: true })).toBe(
+      true,
+    );
+  });
+
+  it("ignores non-focus navigation state", () => {
+    expect(shouldStartComposingFromLocationState(null)).toBe(false);
+    expect(shouldStartComposingFromLocationState({})).toBe(false);
+    expect(
+      shouldStartComposingFromLocationState({ focusPrompt: false }),
+    ).toBe(false);
+  });
+});
+
 describe("shouldNavigateAfterThreadCreate", () => {
   it("follows the preference for ordinary new threads", () => {
     expect(

apps/app/src/views/RootComposeView.tsx

@@ -245,6 +245,13 @@ export function readRootComposeFolderTargetFromLocationState(
   return null;
 }
 
+export function shouldStartComposingFromLocationState(state: unknown): boolean {
+  if (typeof state !== "object" || state === null) {
+    return false;
+  }
+  return "focusPrompt" in state && state.focusPrompt === true;
+}
+
 type RootComposeViewProps =
   | {
       surface: "page";
@@ -749,7 +756,9 @@ export function RootComposeView(props: RootComposeViewProps) {
   );
   // The no-projects welcome replaces the composer until the user opts in; once
   // they pick "New thread" we reveal the composer for the rest of the session.
-  const [startedComposing, setStartedComposing] = useState(false);
+  const [startedComposing, setStartedComposing] = useState(() =>
+    shouldStartComposingFromLocationState(location.state),
+  );
   const [navigateToThreadAfterCreate] =
     useNavigateToThreadAfterCreatePreference();
   const [forkSeed, setForkSeed] = useState<ForkThreadCreateSeed | null>(() =>
@@ -904,6 +913,9 @@ export function RootComposeView(props: RootComposeViewProps) {
     if (!hasSingleUseRootComposeTargetState(location.state)) {
       return;
     }
+    if (shouldStartComposingFromLocationState(location.state)) {
+      setStartedComposing(true);
+    }
     if (folderTarget?.kind === "set") {
       setRootComposeFolderId(folderTarget.folderId);
     } else if (folderTarget?.kind === "clear") {