Skip to content

Correct provider-bridge environment inheritance documentation #2723

Open

Description

@plx

The work

Correct the provider-bridge environment documentation in docs/provider-bridge-protocol.md and its matching Plugin SDK declaration comment. Current main says:

The bridge's own environment is constructed by the runtime from an allowlist; bridges construct their children's environments the same way and must not leak their own inherited env downward (#1366, #1545).

The docs should instead describe the shipped denylist behavior without changing runtime or bridge behavior.

Why now

On main at f4bbc2fe81a9b7639ff9a7396e172bddd89109e4, sanitizeInheritedChildProcessEnv removes only NODE_ENV, BB_*, and undefined values while retaining the rest of the inherited environment. spawnProvider overlays the runtime and bridge-specific environment on that result, and withoutBridgeRuntimeEnv removes only ELECTRON_RUN_AS_NODE and BB_PROVIDER_BRIDGE_RECORD_DIR from provider-child environments.

The allowlist wording was introduced by commit c5b53caab5 in #1640 even though that commit's bridge spawn path used the existing denylist. #1366 established removal of inherited bb thread context, #1402 covers provider-process pipe and replacement races, and #1545 documents a non-bb Volta variable that continued to pass through. Searches for the quoted sentence and equivalent provider-bridge environment claims found no existing issue.

Acceptance criteria

  • State which inherited names the runtime removes, how PATH, bridge variables, and declared env.passthrough values are overlaid, and which bridge-runtime names provider-child builders remove.
  • Preserve intentional inheritance of ordinary provider auth, proxy, and platform variables.
  • Remove the duplicate allowlist claim from the Plugin SDK declaration comment and the record-mode paragraph; leave unrelated allowlists untouched.
  • Make no executable-code or provider-environment behavior change.

AGENT GENERATED

Activity

  1. added theissue type on Aug 30, 2026
  2. added
    documentationImprovements or additions to documentation
    pluginsPlugin SDK, runtime, marketplace
    confirmed-reproBug reproduced again from a clean trusted checkout; see linked report
    on Aug 30, 2026
  3. bb-slop-cop commented on Aug 30, 2026

    @bb-slop-cop
    Contributor

    🚨 SLOP COP 🚨 · new-issue-autopilot

    Type: Bug · Priority: Low · Effort: Low

    Labels: documentation, plugins, confirmed-repro

    Report: https://get-bb.github.io/reports/issues/2723.html

    Verdict: REPRODUCED · Confidence: high

    Root cause: The guide and Plugin SDK declaration describe a general allowlist, but the runtime and child helper use narrow denylists.

    Reproduction label: confirmed-repro

    No new pull request was safe because an open linked pull request already exists: #2725

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    confirmed-reproBug reproduced again from a clean trusted checkout; see linked reportdocumentationImprovements or additions to documentationpluginsPlugin SDK, runtime, marketplace

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions