chore: move to container based titanoboa#66
Draft
inffy wants to merge 1 commit into
Draft
Conversation
Up to standards ✅🟢 Issues
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the Aurora ISO build pipeline to the newer container-based Titanoboa approach by building a “live build” container image that performs the ISO rootfs customization and provides image-builder configuration.
Changes:
- Add a
Containerfile+iso_files/build.shto assemble the live build environment and embed ISO image-builder config (iso_files/iso.yaml). - Update the reusable GitHub Actions workflow to build and pass a locally-built live container image into Titanoboa.
- Align flatpak list generation/cleanup paths to
iso_files/flatpaks.listand extendjust test-iso-configto validate the new script(s).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
Justfile |
Moves flatpak list output/cleanup under iso_files/ and updates syntax-check recipe to include the new build script. |
iso_files/iso.yaml |
Adds image-builder ISO label and GRUB boot entries configuration used by the new container build flow. |
iso_files/configure_iso_anaconda.sh |
Updates image ref/tag sourcing to optionally use BASE_IMAGE provided by the container-based pipeline. |
iso_files/build.sh |
New container build script to install required packages, configure live environment, and stage ISO builder config. |
Containerfile |
New container build definition that runs the ISO build script during image build. |
.github/workflows/reusable-build-iso-anaconda.yml |
Builds the live container image and passes it to Titanoboa instead of using hook/flatpak-list inputs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+5
to
+7
| if [[ -n "${BASE_IMAGE:-}" ]]; then | ||
| IMAGE_REF="${BASE_IMAGE%%:*}" | ||
| IMAGE_TAG="${BASE_IMAGE##*:}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the ISOs to use the new container based titanoboa.
Probably not the cleanest implementation but tested on my fork and ISOs work and install correctly.
Go ham if you figure out a cleaner/better way for implementation.
We can probably get rid of the Justfile if we want to
#58