Skip to content

src/cyw43: Terminate failed initial joins and preserve status. - #170

Closed
dimitri-cl wants to merge 2 commits into
georgerobotics:mainfrom
dimitri-cl:fix/initial-join-termination
Closed

dimitri-cl wants to merge 2 commits into
georgerobotics:mainfrom
dimitri-cl:fix/initial-join-termination

Conversation

@dimitri-cl

@dimitri-cl dimitri-cl commented Oct 13, 2026 •

Copy link
Copy Markdown

Separate initial join handling from established-connection recovery. When an initial join fails, stop pending rejoin activity and retain its failure status until a new join starts or station leave succeeds.

Preserve existing recovery after an established connection and report incompatible security settings as CYW43_LINK_ENCR_MISMATCH.

Related issues:

Separate initial join handling from established-connection recovery. When an initial join fails, stop pending rejoin activity and retain its failure status until a new join starts or station leave succeeds.

Preserve existing recovery after an established connection and report incompatible security settings as CYW43_LINK_ENCR_MISMATCH.

Refs #1
@dimitri-cl

dimitri-cl commented Oct 13, 2026 •

Copy link
Copy Markdown
Author

To further clarify, this change originated from connection attempts with an incorrect password remaining at CYW43_LINK_JOIN instead of reporting CYW43_LINK_BADAUTH. In the observed event sequences, association completed, but the WPA key exchange failed before successful PSK_SUP completion. The driver scheduled another internal join, allowing the original failure to be replaced by CYW43_LINK_JOIN or a later result. Support for encryption mismatch was added after discovering that this event was not handled.

@dimitri-cl

Copy link
Copy Markdown
Author

This PR did not attract review, likely because it combines substantial changes to initial-join and retry behavior with a new public link status.

I created #174 and #175 to describe the two problems separately and allow the intended behavior to be discussed independently of this implementation.

I am updating the references and closing this PR. If changes are still needed after that discussion, one or more smaller PRs can be created, or the issues can be addressed in a way that better matches the intended driver design.

@dimitri-cl dimitri-cl closed this Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant