fix(dashboard): Config tab rendered in a narrow column — restore the grid#58
Conversation
…grid `#configPage` carried `class='grid'` but `renderConfig` wrote its cards into an inner `<div id='config'>` — a plain block that is the section's only grid child. So the cards sat one level too deep: their `span12` had no grid context, and `#config` itself took a single 1/12 track. The whole tab crammed into a thin left column with the labels/inputs clipped (see before/after). - `#config` IS the grid now (`<div class='grid' id='config'>`), so the provider cards are direct grid children and their span classes apply — matching how every other page (activity, builder…) nests `.card spanN` under `.grid`. - Repaint each provider as a `.card span6` (two-up on desktop, full-width under 1040px via the existing media query) with a `.toolbar` header + knob count, and lay each knob on a `.cfgRow` grid (description | control | actions) so labels, inputs and Save/Reset align down the card instead of wrapping ragged. Render-only; the data (`/dashboard/api/config`), the save path (`saveConfigKnob`/`postConfig`) and the knob ids (`cfg_<key>`, `data-kind`) are untouched. Validated by running renderConfig against settings.current()-shaped input: balanced markup, span6 cards, list/num inputs, override pills and reset wiring all present. Suite (config/settings/dashboard) 69/0.
|
Warning Review limit reached
Next review available in: 50 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
The bug
The Config tab rendered as a thin left column with labels and inputs clipped (operator couldn't read or use the knobs).
Root cause:
#configPagehadclass='grid', butrenderConfigwrites its provider cards into an inner<div id='config'>— a plain block that is the section's only grid child. The.card span12cards were therefore one level too deep (no grid context forspan12), and#configitself occupied a single 1/12 track. Every other page (activity, builder, …) nests.card spanNdirectly under the.grid; Config was the odd one out.The fix (render-only)
#configIS the grid now —<div class='grid' id='config'>— so the provider cards are direct grid children and span classes apply..card span6(two-up on desktop; the existing@media(max-width:1040px)rule already collapsesspan6→span12), with a.toolbarheader + knob count..cfgRowgrid — description | control | actions — so labels, inputs and Save/Reset align down the card instead of wrapping raggedly. List inputs (peer allow/deny) and number inputs fill their control column.Not touched
The data endpoint (
/dashboard/api/config→settings.current()), the save path (saveConfigKnob/postConfig), and the input contract (cfg_<key>ids,data-kind) are unchanged.Verification
renderConfigexecuted againstsettings.current()-shaped input: balanced markup,span6cards,.toolbarheaders,.cfgRowrows, list and number inputs,overridepills, Save + Reset wiring — all present; group order and pluralized knob badges correct.Follow-up to the modular-providers refactor (#57) — same Config tab, now legible.