Skip to content

chore(core): bump engine to a3bf98e — adopt served_by_eq (peer-level policy selection)#48

Merged
jmlago merged 1 commit into
mainfrom
core-bump-served-by-eq
Jun 30, 2026
Merged

chore(core): bump engine to a3bf98e — adopt served_by_eq (peer-level policy selection)#48
jmlago merged 1 commit into
mainfrom
core-bump-served-by-eq

Conversation

@jmlago

@jmlago jmlago commented Jun 30, 2026

Copy link
Copy Markdown
Member

What

Bumps the core submodule (unhardcoded-engine) 537e204 → a3bf98e, adopting #24: the served_by_eq predicate.

served_by_eq selects by the executed route — a marketplace peer (offer.peer_id), or the provider for a direct route — the same notion the host already records as calls.served_by. A policy can now pin or exclude a specific peer, not just a whole provider:

["or", ["served_by_eq", "peerA"], ["served_by_eq", "peerB"]]   // only these peers   (served_by_in)
["not", ["served_by_eq", "peerBad"]]                            // drop a peer        (served_by_not_in)

Why this is the whole adoption

The host passes policy_ir straight through to the engine (validation + interpretation live in core), so there's no host-side predicate registry to update. Adoption = the submodule bump + the policy-authoring docs.

SKILL.md

  • Corrects the now-false note "targeting a specific provider/peer is not a policy concern" → peer targeting is expressible via served_by_eq.
  • Adds the predicate to the reference table.
  • Keeps the guidance: prefer gating on properties (reputation_score, success_rate) over pinning peer ids, which rot as peers churn — served_by_eq is for a trusted-peer allowlist, not the default.

Verification

Full suite (engine embedded via lupa) 404 passed / 3 skipped / 0 failed; test_skill_md green with the doc edits.

…policy selection)

Pulls unhardcoded-engine #24: the `served_by_eq` predicate, which selects by the
executed route (a marketplace peer, or the provider for a direct route) — the same
notion the host already records as calls.served_by. A policy can now pin or exclude
a specific peer (or(served_by_eq …) / not(…), sugar served_by_in / served_by_not_in),
not just a whole provider via provider_eq.

The host passes policy_ir straight through to the engine, so adoption is the
submodule bump plus the SKILL.md guidance: peer targeting IS now expressible — the
old "not a policy concern" note is corrected — but prefer gating on properties
(reputation_score, success_rate) over pinning peer ids, which rot as peers churn.
@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@jmlago, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 33 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1f8e1d1b-6b02-4847-ab6a-a10ff5147445

📥 Commits

Reviewing files that changed from the base of the PR and between addc87e and d10db80.

📒 Files selected for processing (2)
  • SKILL.md
  • core
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch core-bump-served-by-eq

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jmlago jmlago merged commit b723b70 into main Jun 30, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant