Skip to content

fix: move misplaced import statements to top of BaseAction.ts#376

Open
ygd58 wants to merge 3 commits into
genlayerlabs:v0.40-devfrom
ygd58:fix/misplaced-imports-baseaction
Open

fix: move misplaced import statements to top of BaseAction.ts#376
ygd58 wants to merge 3 commits into
genlayerlabs:v0.40-devfrom
ygd58:fix/misplaced-imports-baseaction

Conversation

@ygd58

@ygd58 ygd58 commented Jul 9, 2026

Copy link
Copy Markdown

Summary

Moves two misplaced import statements from the middle of BaseAction.ts to the top of the file where all other imports are located.

Problem

Two imports were placed between the resolveNetwork() function and the BaseAction class definition (lines 61-62), likely the result of a botched merge conflict resolution:

export function resolveNetwork(...) {
  // ...
}

import { ethers } from "ethers";                              // misplaced
import { writeFileSync, existsSync, readFileSync } from "fs"; // misplaced

export class BaseAction extends ConfigFileManager {

Fixes #307

Fix

Move both imports to the top of the file with all other import statements.

ygd58 added 3 commits July 9, 2026 15:33
…abs#305)

The reset() method had dead code:
- delete config[key] removed the key from the in-memory object
- writeConfig(key, undefined) then wrote key=undefined back to disk

Replace both lines with removeConfig(key) which correctly
deletes the key and persists the change to disk.

Fixes genlayerlabs#305
…rompt (genlayerlabs#306)

Previously, passing an empty string to setNetwork() was treated as a
valid network name due to the condition:

  if (networkName || networkName === "")

This caused the command to search for a network named "" and always
fail instead of falling through to the interactive prompt.

Fix: simplify the condition to `if (networkName)` so empty strings
are treated the same as undefined, correctly triggering the interactive
network selection prompt.

Fixes genlayerlabs#306
…erlabs#307)

Two import statements were incorrectly placed in the middle of the file
between the resolveNetwork() function and the BaseAction class definition:

  import { ethers } from 'ethers';
  import { writeFileSync, existsSync, readFileSync } from 'fs';

Move them to the top of the file with all other imports.

Fixes genlayerlabs#307
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@ygd58, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 41 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 353dc1d4-40f3-4358-b297-12fde27aff3d

📥 Commits

Reviewing files that changed from the base of the PR and between 3396474 and 004d158.

📒 Files selected for processing (3)
  • src/commands/config/getSetReset.ts
  • src/commands/network/setNetwork.ts
  • src/lib/actions/BaseAction.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot changed the base branch from main to v0.40-dev July 9, 2026 13:40
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

This PR targeted main, which is only the default/static branch.

I retargeted it to v0.40-dev, the active development branch. Pushes to v0.40-dev automatically fast-forward main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Import statements misplaced in middle of file between function and class definitions in BaseAction.ts

1 participant