fix: setNetwork ignores empty string argument and shows interactive prompt#375
fix: setNetwork ignores empty string argument and shows interactive prompt#375ygd58 wants to merge 2 commits into
Conversation
…abs#305) The reset() method had dead code: - delete config[key] removed the key from the in-memory object - writeConfig(key, undefined) then wrote key=undefined back to disk Replace both lines with removeConfig(key) which correctly deletes the key and persists the change to disk. Fixes genlayerlabs#305
…rompt (genlayerlabs#306) Previously, passing an empty string to setNetwork() was treated as a valid network name due to the condition: if (networkName || networkName === "") This caused the command to search for a network named "" and always fail instead of falling through to the interactive prompt. Fix: simplify the condition to `if (networkName)` so empty strings are treated the same as undefined, correctly triggering the interactive network selection prompt. Fixes genlayerlabs#306
|
This PR targeted I retargeted it to |
|
Warning Review limit reached
Next review available in: 43 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Summary
Fixes
setNetworktreating empty string""as a valid network name instead of falling through to the interactive prompt.Problem
The condition
if (networkName || networkName === "")evaluates totruefor empty strings. This causes the command to search for a network named"", fail to find it, and show an error — instead of showing the interactive network selection prompt.Fixes #306
Fix
Simplify the condition to
if (networkName)so that empty strings are treated the same asundefined, correctly triggering the interactive prompt.Before / After