Repository navigation
fix model-id error caused by previous refactor - #46
Merged
Merged
Conversation
jakelorocco
added a commit
that referenced
this pull request
Aug 19, 2025
akihikokuroda
pushed a commit
to akihikokuroda/mellea
that referenced
this pull request
May 27, 2026
spzala
pushed a commit
to spzala/mellea
that referenced
this pull request
Oct 6, 2026
… io.yaml (generative-computing#1706) * chore(adapters): bump granitelib-core pin for fixed requirement-check io.yaml ibm-granite/granitelib-core-r1.0 PR generative-computing#46 (merged 2026-10-05, commit c4b4fc6ec4fa05b6c8f02b25ac8822da085962b5) drops the colon from the requirement-check aLoRA instruction (`<requirements>: {requirement}` -> `<requirements> {requirement}`), so the invocation sequence now survives tokenisation and the adapter activates as published. The pin covers all three core adapter functions (context-attribution, requirement-check, uncertainty); only requirement-check's files changed between the old and new revisions. Removes the strict xfail from test_requirement_check_adapter_moves_score, which needs a GPU and is skipped locally. Closes generative-computing#1699, generative-computing#1679. Assisted-by: Claude Code Signed-off-by: Nigel Jones <jonesn@uk.ibm.com> * docs: sync stale granitelib-core SHA references to the new pin Two mechanical review comments on PR generative-computing#1706 (code-review panel): the schema-migrations tutorial's sample output and the uncertainty Ollama build script still showed the old d0a2a96a pin after the catalog bump. Assisted-by: Claude Code Signed-off-by: Nigel Jones <jonesn@uk.ibm.com> --------- Signed-off-by: Nigel Jones <jonesn@uk.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #37
in a previous version of the code, the model_id was always being stringified here before being checked; this is not the case now, which would cause the check to incorrectly pass even though the value was
Noneall formatter tests still passed, and I added two new tests to check for similar situations