You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Remove deprecated adapter shims (IntrinsicAdapter/EmbeddedIntrinsicAdapter/CustomIntrinsicAdapter) — PR2 of #1144 #1621
Parent:#1144 (PR2 of the two-PR split described there) Depends on:#1619 (PR1 — composed-Adapter-direct path) merging first, with
its own green CI on main as the actual proof nothing still needs the shim
path.
Goal
Remove IntrinsicAdapter, EmbeddedIntrinsicAdapter, and CustomIntrinsicAdapter (mellea/backends/adapters/adapter.py) now that #1619 makes the composed Adapter (Identity + IOContract + a weights
binding) a fully working, additive replacement for every backend. Not urgent
— PR1 changes nothing for existing callers, so this can land whenever a
maintainer picks it up.
This issue exists so the deletion has a home to be scheduled against,
distinct from #1144 (which also tracks PR1). See #1144's "PR2 — delete the
shims" section for the full itemized scope (files, tests to delete, the
required full-repo reference sweep, and acceptance criteria) — not
duplicated here to avoid the two drifting out of sync.
Delete the shim-specific test files/cases (not anything that ended up
covering the composed path instead).
Full-repo sweep (gh api search/code for all three class names) — zero
hits outside changelog/historical text.
Changelog entry with a migration note (import path change for anyone
still constructing a shim directly).
Not before
Do not start this until #1619 has merged and a subsequent CI run on main
confirms the composed path alone is sufficient — that run is the acceptance
gate, not a comment claiming it.
Activity
fix(backends): fix Qwen-review findings on composed-Adapter path (gen…
feat(backends): accept composed Adapter directly (Epic generative-com…
docs(adapters): trim transient issue references from aLoRA guard docs
fix(adapters): raise or fall back when an aLoRA cannot activate (gene…
fix(adapters): raise or fall back when an aLoRA cannot activate (gene…
fix(adapters): raise or fall back when an aLoRA cannot activate (gene…
fix(adapters): raise or fall back when an aLoRA cannot activate (gene…