Update substrate#1038
Merged
Merged
Conversation
breathx
reviewed
Jun 9, 2022
Contributor
c71d125Pallet tests (values are in nanosegconds)Total execution time
name = pallet-gas
name = pallet-gear
name = pallet-gear-debug
name = pallet-gear-messenger
name = pallet-gear-payment
name = pallet-gear-program
name = pallet-usage
Runtime tests (values are in nanoseconds)Total execution time
name = Async RwLock
name = Async init
name = Async-await
name = Async-duplicates-sync
name = Async-multisig (well known cases)
name = Async-sign (well known cases)
name = Basic capacitor check
name = Decoder
name = Futures-unordered
name = Incomplete-async-payloads
name = Memory test
name = Messages to failed program are handled properly
name = Meta ping (simple check)
name = Multiping
name = Ping-pong
name = Program_id test
name = State-rollback
name = Test create_program sys-call
name = Trap test
name = Wait test
name = basic
name = collector-1
name = guestbook test
name = gui test
1352194Pallet tests (values are in nanoseconds)Total execution time
name = pallet-gas
name = pallet-gear
name = pallet-gear-debug
name = pallet-gear-messenger
name = pallet-gear-payment
name = pallet-gear-program
name = pallet-usage
Runtime tests (values are in nanoseconds)Total execution time
name = Async RwLock
name = Async init
name = Async-await
name = Async-duplicates-sync
name = Async-multisig (well known cases)
name = Async-sign (well known cases)
name = Basic capacitor check
name = Decoder
name = Futures-unordered
name = Incomplete-async-payloads
name = Memory test
name = Messages to failed program are handled properly
name = Meta ping (simple check)
name = Multiping
name = Ping-pong
name = Program_id test
name = State-rollback
name = Test create_program sys-call
name = Trap test
name = Wait test
name = basic
name = collector-1
name = guestbook test
name = gui test
|
Codecov Report
@@ Coverage Diff @@
## master #1038 +/- ##
==========================================
- Coverage 73.49% 73.39% -0.11%
==========================================
Files 89 89
Lines 8626 8898 +272
==========================================
+ Hits 6340 6531 +191
- Misses 2286 2367 +81
Continue to review full report at Codecov.
|
grishasobol
approved these changes
Jun 11, 2022
shamilsan
approved these changes
Jun 12, 2022
breathx
reviewed
Jun 13, 2022
| wrap_storage_map!(storage: $storage, name: $name, key: $key, value: $val, counted None); | ||
| }; | ||
| (storage: $storage: ident, name: $name: ident, key: $key: ty, value: $val: ty, counted $($rm_arg:expr)?) => { | ||
| (storage: $storage: ident, name: $name: ident, key: $key: ty, value: $val: ty,) => { |
Member
There was a problem hiding this comment.
There should no be trailing comma after macro args
| /// The custom benchmark subcommand benchmarking runtime pallets. | ||
| #[clap(name = "benchmark", about = "Benchmark runtime pallets.")] | ||
| /// Sub-commands concerned with benchmarking. | ||
| #[clap(subcommand)] |
Member
There was a problem hiding this comment.
Why the explanation from subcommand were removed?
| #[cfg(not(feature = "try-runtime"))] | ||
| TryRuntime, | ||
|
|
||
| /// Db meta columns information. |
| @@ -16,7 +16,7 @@ pallet-gear = { version = "2.0.0", default-features = false, path = "../../../ge | |||
| [features] | |||
| default = ["std"] | |||
| std = [ | |||
Member
There was a problem hiding this comment.
Shouldn't sp-std/std be also included?
| fn runtime_error_into_rpc_error(err: impl std::fmt::Debug) -> JsonRpseeError { | ||
| CallError::Custom(ErrorObject::owned( | ||
| 8000, | ||
| "Runtime error", |
Member
There was a problem hiding this comment.
"RPC call error" mostly suitable for me, just because it not only relays on runtime logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#[transactional]Storage Layer for All FRAME Extrinsics paritytech/substrate#11431WeightToFeeinstead ofWeightToFeePolynomialIntroduceWeightToFeetrait instead ofWeightToFeePolynomialand makeWeightToFeePolynomialimplement it instead paritytech/substrate#11415pallet-gear-rpc@gear-tech/dev