Repository navigation
fix: design-doc discovery reads docs/designs/ only — a root DESIGN.md is the design system (#2839) - #2840
Closed
Bit0ps wants to merge 1 commit into
Closed
fix: design-doc discovery reads docs/designs/ only — a root DESIGN.md is the design system (#2839)#2840Bit0ps wants to merge 1 commit into
Bit0ps wants to merge 1 commit into
Conversation
… is the design system, never the design doc The shared DESIGN_DOC_DISCOVERY block took a repo-root DESIGN.md as the phase's design doc ahead of docs/designs/*.md, and ahead of the private copy whenever it was newer — unconditionally on a checkout with no private copy. Since the open DESIGN.md format, that file is the design system /design-consultation writes: tokens, not a problem statement. So on any project holding both, plan-ceo-review, plan-eng-review, plan-devex-review, autoplan and review's prerequisite re-check reviewed a plan against a colour palette while printing "Design doc found: DESIGN.md", and the office-hours prerequisite offer never fired because a doc had been found. Drop the root check; docs/designs/*.md stays the repo-local design doc, with the garrytan#703 freshness rule unchanged. Regenerated the four skills; a test pins that none of them names _REPOTOP/DESIGN.md again. Fixes garrytan#2839 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
An error occurred while submitting your PR to the queue: |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
DESIGN_DOC_DISCOVERYno longer takes a repo-rootDESIGN.mdas the phase's design doc. Onlydocs/designs/*.mdis a repo-local design doc; the #703 freshness rule against the private copy is unchanged.Why
Since the open
DESIGN.mdformat (v1.84.0.0), the root file is the design system/design-consultationwrites — tokens and spec sections, no problem statement. The block preferred it todocs/designs/*.md, and to~/.gstack/projects/<slug>/*-design-*.mdwhenever it was newer; on a checkout with no private copy (a fresh clone, a server) unconditionally. So a project holding both files hadplan-ceo-review,plan-eng-review,plan-devex-review,autoplanandreview's prerequisite re-check reasoning from a colour palette while printingDesign doc found: DESIGN.md, and the/office-hoursprerequisite offer never fired because a doc had been found. Full measurement in #2839.Changes
scripts/resolvers/design-doc-discovery.ts: remove the$_REPOTOP/DESIGN.mdbranch; comments say whyautoplan,plan-ceo-review,plan-devex-review,plan-eng-review(bun run gen:skill-docs --host all, no other file moved)test/gen-skill-docs.test.ts: the four skills look indocs/designs/only and never name_REPOTOP/DESIGN.mdVerified
bun test test/gen-skill-docs.test.ts— 440 pass, 0 fail.Fixes #2839
🤖 Generated with Claude Code