Repository navigation
fix(test): hermetic-wiring skill-seeding tripwire can never pass on default ~/.claude installs - #2586
Closed
sneakygriff wants to merge 1 commit into
Closed
sneakygriff wants to merge 1 commit into
sneakygriff wants to merge 1 commit into
Conversation
…~/.claude ban The skill-seeding tripwire asserted every seeded symlink target must NOT start with ~/.claude — but on the default global-git install the repo itself lives at ~/.claude/skills/gstack, so every CORRECT symlink (which must resolve into the live repo tree, as the very next assertion requires) carried the banned prefix. The test could never pass on a default install: pristine v1.64.1.0 (c118e24) fails it in any worktree under ~/.claude/skills/ and passes elsewhere (verified 2026-08-15). Exempt targets that realpath into the resolved repo ROOT before applying the operatorClaude ban — realpath both sides so a symlinked HOME can't dodge the tripwire. Genuine escapes (a target under ~/.claude but outside the repo) still fail with the escape message. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
4 of 9 tasks
Owner
|
Thank you — this landed in v1.67.0.0 (credited in the CHANGELOG). Closing since the fix is on main. 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The tripwire
skill seeding stays under runRoot and reads the live repo tree, never operator ~/.claudeasserts every seeded symlink target must NOT start with~/.claude— and then that it MUST resolve into the live repo tree. On the default global-git install the repo itself lives at~/.claude/skills/gstack, so every correct symlink carries the banned prefix: the two assertions can never both hold.Evidence
Pristine
c118e240(v1.64.1.0), verified 2026-08-15 on macOS arm64:~/.claude/skills/→ the seeding test fails (pair-agent: symlink escapes to .../pair-agent/SKILL.md)CI never sees this because dev checkouts don't live under
~/.claude— but every user following the README install path who runs the suite does.Fix
Targets that
realpathinto the resolved repo ROOT are exempted before the operator-~/.claudeban (both sides realpath'd, so a symlinked $HOME can't dodge the tripwire). Genuine escapes — a target under~/.claudebut outside the repo — still fail with the specific escape message.Verification
bun test test/hermetic-wiring.test.ts: 5/5 pass both at~/.claude/skills/gstackand at a non-~/.claudeworktree of this branch.🤖 Generated with Claude Code