Skip to content

fix: preserve gbrain argv on Windows without a shell - #2453

Closed
stslgn wants to merge 2 commits into
garrytan:mainfrom
stslgn:codex/gstack-1.60.1-shellfree
Closed

stslgn wants to merge 2 commits into
garrytan:mainfrom
stslgn:codex/gstack-1.60.1-shellfree

Conversation

@stslgn

@stslgn stslgn commented Aug 4, 2026 •

Copy link
Copy Markdown

Summary

  • run direct gbrain invocations through cross-spawn without shell: true
  • centralize synchronous, text, and asynchronous argv handling
  • preserve source IDs, paths, and search arguments as literal argv values
  • exercise the regression in the existing windows-latest test job

Why

On Windows, launching the gbrain.cmd shim through Node's shell mode can reinterpret argument metacharacters. cross-spawn resolves the command shim while keeping the argument vector separate from a composed shell command.

This is a focused alternative to #2272. That PR includes broader Windows runtime and release changes; this one intentionally limits scope to direct gbrain process creation and its regression coverage.

Validation

  • bun run build
  • targeted gbrain tests: 38 passed, 0 failed
  • full bun run test completed locally with exit 0; relevant targeted tests are clean

Windows CI now runs both the argv round-trip and shell-free adapter invariants.

@trunk-io

trunk-io Bot commented Aug 4, 2026

Copy link
Copy Markdown

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@stslgn

stslgn commented Aug 4, 2026

Copy link
Copy Markdown
Author

CI is waiting for first-time-contributor approval: all seven pull-request workflows currently report action_required, including Windows Free Tests, which is the key gate for this change.

Could a maintainer please approve and run the workflows? I will keep the PR in Draft until the Windows job is green.

@garrytan

Copy link
Copy Markdown
Owner

Closing: this was absorbed or superseded on main by v1.67.0.0 or earlier (see the v1.67 tracker-wave receipts in PR #2604). Thank you!

@garrytan garrytan closed this Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants