Repository navigation
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Author
|
CI is waiting for first-time-contributor approval: all seven pull-request workflows currently report Could a maintainer please approve and run the workflows? I will keep the PR in Draft until the Windows job is green. |
4 of 9 tasks
Owner
|
Closing: this was absorbed or superseded on main by v1.67.0.0 or earlier (see the v1.67 tracker-wave receipts in PR #2604). Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gbraininvocations throughcross-spawnwithoutshell: truewindows-latesttest jobWhy
On Windows, launching the
gbrain.cmdshim through Node's shell mode can reinterpret argument metacharacters.cross-spawnresolves the command shim while keeping the argument vector separate from a composed shell command.This is a focused alternative to #2272. That PR includes broader Windows runtime and release changes; this one intentionally limits scope to direct
gbrainprocess creation and its regression coverage.Validation
bun run buildbun run testcompleted locally with exit 0; relevant targeted tests are cleanWindows CI now runs both the argv round-trip and shell-free adapter invariants.