Repository navigation
Conversation
Fixes garrytan#2382. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
4 of 9 tasks
Owner
|
Thank you — this was absorbed on main (credited in the v1.6x CHANGELOG entries; roster in PR #2604). Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2382 —
gstack-settings-hook add-eventdeduplicates on(event, matcher, _gstack_source)but ignores thecommandfield. When an entry loses its_gstack_sourcetag (or is re-registered under a different source), the same hook command is appended as a duplicate — firing N times per matching tool call.The fix adds
commandto the match predicate: an entry with the same(event, matcher, command)is now treated as the same hook regardless of source tag. On match, the existing entry is updated in place (including refreshing its_gstack_source), preventing duplication and makingadd-eventself-healing for untagged entries.Verification
bun test test/gstack-settings-hook-schema-aware.test.tsgreen (15/15)bin/gstack-settings-hookcauses both failuresCo-Authored-By: Claude Opus 4.6 noreply@anthropic.com