Skip to content

fix(diff-scope): detect backend code in .mjs/.cjs/.mts/.cts files #1811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jbetala7 wants to merge 1 commit into from
Closed

fix(diff-scope): detect backend code in .mjs/.cjs/.mts/.cts files #1811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/gstack-diff-scope
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ while IFS= read -r f; do

# Backend: everything else that's code (excluding views/components already matched)
*.rb|*.py|*.go|*.rs|*.java|*.php|*.ex|*.exs) BACKEND=true ;;
*.ts|*.js) BACKEND=true ;; # Non-component TS/JS is backend
*.ts|*.mts|*.cts|*.js|*.mjs|*.cjs) BACKEND=true ;; # Non-component TS/JS is backend (incl. ESM .mjs/.mts + CJS .cjs/.cts)
esac
done <<< "$FILES"

Expand Down
11 changes: 11 additions & 0 deletions test/diff-scope.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,17 @@ describe('gstack-diff-scope', () => {
expect(scope.SCOPE_TESTS).toBe('true');
});

test('detects backend via ESM/CJS extensions (.mjs/.cjs/.mts/.cts)', () => {
// Pure-ESM Node projects ship backend code as .mjs/.cjs (and explicit-module
// TypeScript as .mts/.cts). These must register as backend so the review
// army's backend/security reviewers fire on such changes.
for (const f of ['server.mjs', 'helper.cjs', 'mod.mts', 'legacy.cts']) {
const dir = createRepo([f]);
const scope = runScope(dir);
expect(scope.SCOPE_BACKEND).toBe('true');
}
});

// --- New scope signals (Review Army) ---

test('detects migrations via db/migrate/', () => {
Expand Down
Loading