v1.54.0.0 feat: carve /ship into skeleton + on-demand sections (-59% always-loaded)

CHANGELOG.md

@@ -1,5 +1,44 @@
 # Changelog
 
+## [1.54.0.0] - 2026-05-30
+
+## **The heaviest skill stopped taxing every session. /ship's always-loaded cost dropped 59%, and its prose now loads only when a step needs it.**
+
+`/ship` was a 167KB wall that every session paid for in full, whether you were bumping a version or writing a changelog or none of it. It is now a 69KB decision-tree skeleton plus eight `sections/*.md` files the agent opens on demand. The eight steps that are long prose (the test run, coverage audit, plan-completion, the review army, Greptile triage, the adversarial pass, the changelog, the PR body) moved into sections behind STOP-Read pointers, so a run only reads the chapters its situation calls for. The version-bump logic that used to be ~90 lines of inline bash, the single worst re-bump footgun in the workflow, is now the tested `gstack-version-bump` CLI (classify / write / repair). Other hosts (codex, factory, kiro, opencode) keep the full inline skill unchanged, so nothing regresses off Claude. This release dogfooded itself: the version you are reading was bumped by `gstack-version-bump`.
+
+### The numbers that matter
+
+Measured directly from the generated skill (`wc -c ship/SKILL.md`) and the new section files, regenerated for all hosts:
+
+| Metric | Before (v1.53) | After (v1.54) | Δ |
+|--------|----------------|---------------|---|
+| ship always-loaded | 167 KB (~41.8K tokens) | 69 KB (~17.2K tokens) | -59% |
+| ship prose loaded per run | all of it | only applicable sections | on-demand |
+| ship version logic | ~90 lines inline bash | tested CLI, 15 unit tests | extracted |
+| External-host ship | 167 KB inline | 162 KB inline (unchanged behavior) | no regression |
+
+The skeleton is what loads the instant `/ship` is invoked, so the ~24.6K-token drop is paid back on every single ship, not just once.
+
+### What this means for you
+
+A `/ship` run starts ~3x lighter and pulls in each heavy step's instructions only when it reaches that step, so the agent spends less of its window holding prose it is not using yet. You will not notice any behavior change. The workflow is identical step for step; the difference is what is in context when. If you ever want to read a step in isolation, the chapters live at `~/.claude/skills/gstack/ship/sections/`.
+
+### Itemized changes
+
+#### Added
+- `bin/gstack-version-bump` — tested version-state CLI (classify / write / repair) with 15 unit tests covering the full FRESH / ALREADY_BUMPED / DRIFT_STALE_PKG / DRIFT_UNEXPECTED matrix.
+- `ship/sections/*.md` — eight on-demand sections (tests, test-coverage, plan-completion, review-army, greptile, adversarial, changelog, pr-body) with a passive `manifest.json` registry.
+- Section pipeline in `gen-skill-docs`: `{{SECTION:id}}` (STOP-Read pointer on Claude, inline on other hosts) and `{{SECTION_INDEX}}` (situation to section table rendered from the manifest).
+- `test/helpers/transcript-section-logger.ts` + `required-reads.ts` and section-loading / manifest-consistency / context-parity tests guarding the carve.
+
+#### Changed
+- `/ship` is a skeleton + sections on Claude; external hosts still receive the full inline skill (no behavior change off Claude).
+- Step 12 calls `gstack-version-bump` instead of inline bash.
+- Parity harness understands carved skills (checks skeleton + sections union; asserts the skeleton actually shrank).
+
+#### For contributors
+- `setup` links `sections/` into the prefixed Claude + Kiro skill dirs; `--host all` now fails the build on any host failure, not just claude.
+- New section templates live at `<skill>/sections/*.md.tmpl`; regenerate with `bun run gen:skill-docs`.
 ## [1.53.1.0] - 2026-05-30
 
 ## **Workspace and scripted setup never hang on a hidden prompt again. Installing the plan-tune hooks is now flag-driven with safe defaults.**

VERSION

@@ -1 +1 @@
-1.53.1.0
+1.54.0.0

bin/gstack-version-bump

@@ -0,0 +1,212 @@
+#!/usr/bin/env bun
+// gstack-version-bump — deterministic version-state classifier + writer for /ship.
+//
+// Extracted from ship Step 12 prose (v2 plan T9, hybrid CLI extraction). The
+// idempotency classification and the dual-write to VERSION + package.json are
+// pure deterministic logic; running them as tested code removes the single
+// worst /ship footgun — re-bumping an already-shipped branch — from prose the
+// agent could skip or misread when the step lives in a lazy-loaded section.
+//
+// What STAYS agent judgment (NOT here): the bump-LEVEL decision (micro/patch vs
+// minor/major, which may AskUserQuestion on feature signals) and the queue
+// collision prompt. The slot pick itself is bin/gstack-next-version. This CLI
+// only answers "what state am I in?" and "write this exact version".
+//
+// Subcommands:
+//   classify --base <branch> [--version-path <p>]
+//       Compares VERSION vs origin/<base>:VERSION vs package.json.version.
+//       Emits JSON: { state, baseVersion, currentVersion, pkgVersion, pkgExists }
+//       state ∈ FRESH | ALREADY_BUMPED | DRIFT_STALE_PKG | DRIFT_UNEXPECTED
+//       Exit 0 on a decidable state (incl. DRIFT_UNEXPECTED — it's a real state
+//       the caller must handle), exit 2 on bad args / unresolvable base.
+//
+//   write --version <X.Y.Z.W> [--version-path <p>]
+//       Validates the 4-digit pattern, writes VERSION + package.json.version.
+//       Use for the FRESH bump (or an approved queue rebump). Exit 3 on a
+//       half-write (VERSION written, package.json failed) so the caller knows
+//       drift exists; the next classify() will report DRIFT_STALE_PKG.
+//
+//   repair [--version-path <p>]
+//       DRIFT_STALE_PKG path: sync package.json.version to the current VERSION
+//       file. No bump. Validates the VERSION pattern first.
+//
+// Contract: classify NEVER writes. write/repair mutate VERSION + package.json
+// only. No git mutation, no network. Mirrors gstack-next-version's reader/writer
+// split so /ship composes them.
+
+import { existsSync, readFileSync, writeFileSync } from "node:fs";
+import { execFileSync } from "node:child_process";
+import { join } from "node:path";
+
+const VERSION_RE = /^[0-9]+\.[0-9]+\.[0-9]+\.[0-9]+$/;
+const DEFAULT = "0.0.0.0";
+
+type State = "FRESH" | "ALREADY_BUMPED" | "DRIFT_STALE_PKG" | "DRIFT_UNEXPECTED";
+
+function fail(msg: string, code = 2): never {
+  process.stderr.write(`gstack-version-bump: ${msg}\n`);
+  process.exit(code);
+}
+
+function argVal(args: string[], flag: string): string | undefined {
+  const i = args.indexOf(flag);
+  return i >= 0 && i + 1 < args.length ? args[i + 1] : undefined;
+}
+
+/** Resolve the VERSION file path: --version-path, else .gstack/version-path, else "VERSION". */
+function resolveVersionPath(cwd: string, explicit?: string): string {
+  if (explicit) return join(cwd, explicit);
+  const pin = join(cwd, ".gstack", "version-path");
+  if (existsSync(pin)) {
+    const p = readFileSync(pin, "utf-8").trim();
+    if (p) return join(cwd, p);
+  }
+  return join(cwd, "VERSION");
+}
+
+function readVersionFile(p: string): string {
+  try {
+    const v = readFileSync(p, "utf-8").replace(/[\r\n\s]/g, "");
+    return v || DEFAULT;
+  } catch {
+    return DEFAULT;
+  }
+}
+
+/** package.json version + existence, parsed without spawning node. */
+function readPkgVersion(cwd: string): { exists: boolean; version: string } {
+  const pkgPath = join(cwd, "package.json");
+  if (!existsSync(pkgPath)) return { exists: false, version: "" };
+  let raw: string;
+  try {
+    raw = readFileSync(pkgPath, "utf-8");
+  } catch {
+    return { exists: true, version: "" };
+  }
+  let parsed: unknown;
+  try {
+    parsed = JSON.parse(raw);
+  } catch {
+    fail("package.json is not valid JSON. Fix the file before re-running /ship.", 2);
+  }
+  const version = (parsed as { version?: unknown })?.version;
+  return { exists: true, version: typeof version === "string" ? version : "" };
+}
+
+function writePkgVersion(cwd: string, version: string): void {
+  const pkgPath = join(cwd, "package.json");
+  const raw = readFileSync(pkgPath, "utf-8");
+  const parsed = JSON.parse(raw) as Record<string, unknown>;
+  parsed.version = version;
+  writeFileSync(pkgPath, JSON.stringify(parsed, null, 2) + "\n");
+}
+
+function baseVersion(cwd: string, base: string, versionRel: string): string {
+  // Verify the base ref resolves, mirroring the Step 12 guard.
+  try {
+    execFileSync("git", ["rev-parse", "--verify", `origin/${base}`], { cwd, stdio: "ignore" });
+  } catch {
+    fail(`Unable to resolve origin/${base}. Run 'git fetch origin' or verify the base branch exists.`, 2);
+  }
+  try {
+    const out = execFileSync("git", ["show", `origin/${base}:${versionRel}`], { cwd }).toString();
+    const v = out.replace(/[\r\n\s]/g, "");
+    return v || DEFAULT;
+  } catch {
+    // VERSION absent on base (new repo / new file) → treat as 0.0.0.0.
+    return DEFAULT;
+  }
+}
+
+function classifyState(current: string, base: string, pkgExists: boolean, pkgVersion: string): State {
+  if (current === base) {
+    // VERSION unchanged vs base. A diverging package.json means someone hand-edited
+    // package.json bypassing /ship — unsafe to guess which is authoritative.
+    if (pkgExists && pkgVersion && pkgVersion !== current) return "DRIFT_UNEXPECTED";
+    return "FRESH";
+  }
+  // VERSION already moved past base.
+  if (pkgExists && pkgVersion && pkgVersion !== current) return "DRIFT_STALE_PKG";
+  return "ALREADY_BUMPED";
+}
+
+function cmdClassify(args: string[], cwd: string): void {
+  const base = argVal(args, "--base");
+  if (!base) fail("classify requires --base <branch>", 2);
+  const versionPath = resolveVersionPath(cwd, argVal(args, "--version-path"));
+  const versionRel = argVal(args, "--version-path") ?? "VERSION";
+  const current = readVersionFile(versionPath);
+  const baseV = baseVersion(cwd, base!, versionRel);
+  const pkg = readPkgVersion(cwd);
+  const state = classifyState(current, baseV, pkg.exists, pkg.version);
+  process.stdout.write(
+    JSON.stringify({
+      state,
+      baseVersion: baseV,
+      currentVersion: current,
+      pkgVersion: pkg.version || null,
+      pkgExists: pkg.exists,
+    }) + "\n",
+  );
+  // DRIFT_UNEXPECTED is a real, decidable state — the caller stops on it, but the
+  // classification itself succeeded, so exit 0. (Bad args / unresolvable base are
+  // the only exit-2 cases.)
+}
+
+function cmdWrite(args: string[], cwd: string): void {
+  const version = argVal(args, "--version");
+  if (!version) fail("write requires --version <X.Y.Z.W>", 2);
+  if (!VERSION_RE.test(version!)) {
+    fail(`NEW_VERSION (${version}) does not match MAJOR.MINOR.PATCH.MICRO. Aborting.`, 2);
+  }
+  const versionPath = resolveVersionPath(cwd, argVal(args, "--version-path"));
+  writeFileSync(versionPath, version + "\n");
+  if (existsSync(join(cwd, "package.json"))) {
+    try {
+      writePkgVersion(cwd, version!);
+    } catch {
+      fail(
+        "failed to update package.json. VERSION was written but package.json is now stale. " +
+          "Re-run — classify will report DRIFT_STALE_PKG and repair will sync it.",
+        3,
+      );
+    }
+  }
+  process.stdout.write(JSON.stringify({ wrote: version, packageJson: existsSync(join(cwd, "package.json")) }) + "\n");
+}
+
+function cmdRepair(args: string[], cwd: string): void {
+  const versionPath = resolveVersionPath(cwd, argVal(args, "--version-path"));
+  const current = readVersionFile(versionPath);
+  if (!VERSION_RE.test(current)) {
+    fail(
+      `VERSION file contents (${current}) do not match MAJOR.MINOR.PATCH.MICRO. ` +
+        "Refusing to propagate invalid semver into package.json. Fix VERSION, then re-run /ship.",
+      2,
+    );
+  }
+  if (!existsSync(join(cwd, "package.json"))) {
+    fail("repair: no package.json to sync.", 2);
+  }
+  try {
+    writePkgVersion(cwd, current);
+  } catch {
+    fail("drift repair failed — could not update package.json.", 3);
+  }
+  process.stdout.write(JSON.stringify({ repaired: current }) + "\n");
+}
+
+// Exported for unit tests (pure logic, no I/O).
+export { classifyState, VERSION_RE, type State };
+
+if (import.meta.main) {
+  const [sub, ...rest] = process.argv.slice(2);
+  const cwd = process.cwd();
+  switch (sub) {
+    case "classify": cmdClassify(rest, cwd); break;
+    case "write": cmdWrite(rest, cwd); break;
+    case "repair": cmdRepair(rest, cwd); break;
+    default:
+      fail("usage: gstack-version-bump <classify|write|repair> [flags]", 2);
+  }
+}

package.json

@@ -1,6 +1,6 @@
 {
   "name": "gstack",
-  "version": "1.53.1.0",
+  "version": "1.54.0.0",
   "description": "Garry's Stack — Claude Code skills + fast headless browser. One repo, one install, entire AI engineering workflow.",
   "license": "MIT",
   "type": "module",

scripts/discover-skills.ts

@@ -26,6 +26,34 @@ export function discoverTemplates(root: string): Array<{ tmpl: string; output: s
   return results;
 }
 
+/**
+ * Discover on-demand section templates: `<skill>/sections/*.md.tmpl`.
+ *
+ * Returns the relative tmpl path, its generated output path (`.tmpl` stripped),
+ * and the owning skill directory so the generator can build a TemplateContext
+ * with the PARENT skill's name (not "sections") — see processSectionTemplate.
+ *
+ * Scans one level of subdirs (same depth as discoverTemplates), looking only
+ * inside a `sections/` child. Skills without a sections/ dir contribute nothing,
+ * so this is a no-op for every skill that hasn't been carved.
+ */
+export function discoverSectionTemplates(
+  root: string,
+): Array<{ tmpl: string; output: string; skillDir: string }> {
+  const results: Array<{ tmpl: string; output: string; skillDir: string }> = [];
+  for (const dir of subdirs(root)) {
+    const sectionsDir = path.join(root, dir, 'sections');
+    if (!fs.existsSync(sectionsDir) || !fs.statSync(sectionsDir).isDirectory()) continue;
+    for (const entry of fs.readdirSync(sectionsDir, { withFileTypes: true })) {
+      if (!entry.isFile() || !entry.name.endsWith('.md.tmpl')) continue;
+      const rel = `${dir}/sections/${entry.name}`;
+      results.push({ tmpl: rel, output: rel.replace(/\.tmpl$/, ''), skillDir: dir });
+    }
+  }
+  // Deterministic order so CI freshness checks don't flap on FS iteration order.
+  return results.sort((a, b) => a.tmpl.localeCompare(b.tmpl));
+}
+
 export function discoverSkillFiles(root: string): string[] {
   const dirs = ['', ...subdirs(root)];
   const results: string[] = [];