Skip to content

Fix Windows build artifact finalization - #1540

Closed
McGluut wants to merge 1 commit into
garrytan:mainfrom
McGluut:codex/fix-windows-bun-build-script
Closed

McGluut wants to merge 1 commit into
garrytan:mainfrom
McGluut:codex/fix-windows-bun-build-script

Conversation

@McGluut

@McGluut McGluut commented May 16, 2026

Copy link
Copy Markdown

Summary

This PR moves the build artifact finalization out of shell subshells and into a small Bun script.

Changes:

  • write the .version files from scripts/finalize-build-artifacts.ts
  • mark built executables from that script when they exist
  • remove root .bun-build temp artifacts without package-script shell syntax
  • make the build stop if xterm vendoring or skill-doc generation fails
  • add a focused test for the finalizer

This should address #1537 and #1538.

Validation

  • bun install --frozen-lockfile
  • bun run build
  • bun test test/finalize-build-artifacts.test.ts
  • git diff --check

@time-attack

Copy link
Copy Markdown
Contributor

@16francej Please close this PR. Windows build finalization, version files, permissions, cleanup, and failure handling are all owned by the newer #1594 build pipeline. This older implementation is fully superseded.

@capy-ai

capy-ai Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Thanks for this, @McGluut. The fix is now on main: the build moved to scripts/build.sh (bash, set -e), so the Bun-shell subshell redirects are gone (already on main as of v1.91.16.0). Closing as superseded; if you still see the problem on the latest gstack, please open an issue with ./setup --status output.

@capy-ai capy-ai Bot closed this Oct 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants