/sync-gbrain --dream: classifyDreamOutcome false-positives 'pack does not extract code symbols' on every base-pack brain #2341

Summary

classifyDreamOutcome in bin/gstack-gbrain-sync.ts (~line 1381) decides the dream stage failed for pack-capability reasons by string-matching the cycle log:

if (/does not declare this phase/i.test(out)) {
  return "dream ran, but this source's schema pack does not extract code symbols, ...";
}

But in gbrain (0.42.26.0), the only emitters of "active pack does not declare this phase" are the content phases — extract_atoms (src/core/cycle.ts:1686) and synthesize_concepts (src/core/cycle.ts:1800). Neither has anything to do with code symbols. On gbrain-base / gbrain-base-v2 (the default packs, which legitimately don't declare those creator-pack phases), every dream cycle log contains the matched string, so /sync-gbrain --dream reports the WARN even when the call-graph build worked.

Versions: gstack 1.60.1.0, gbrain 0.42.26.0, PGLite engine.

Observed

Dream cycle log from a real run (base-v2 pack, TS repo):

  - extract_atoms  extract_atoms: active pack does not declare this phase (run `gbrain dream --phase extract_atoms --drain` to drain a backlog)
  ✓ resolve_symbol_edges  6001 chunk(s) walked; resolved 0, ambiguous 0, unmatched 0
  - synthesize_concepts  synthesize_concepts: active pack does not declare this phase

resolve_symbol_edges ran (✓) — yet the stage summary came out as:

WARN  dream  dream ran, but this source's schema pack does not extract code symbols, so the call graph stays empty. Switch this source to a code-aware schema pack (`gbrain schema use <pack>`) ...

Why it matters

• The WARN's remediation ("switch schema packs") is wrong and costly — no bundled gbrain pack even declares a code-symbol phase, so a user following it churns packs for nothing.
• It masks the real diagnosis. In my case the graph was empty because of a genuine gbrain bug (edges written with NULL source_id — filed as Code edges are written with NULL source_id, so source-scoped code-callers/code-callees always return empty gbrain#3379); the false pack-capability WARN sent debugging in the wrong direction first.
• The /sync-gbrain SKILL.md Step 3.5/Step 5 wording propagates the same claim ("on a non-code-aware pack --dream completes but the graph stays empty"), so the agent-facing docs reinforce the misdiagnosis.

Suggested fix

1. Anchor the match to the phase that actually builds the graph, e.g. only WARN on pack capability if the log lacks a resolve_symbol_edges completion line, or match /(resolve_symbol_edges|extract_code_symbols)[^\n]*does not declare/i instead of the bare phrase.
2. When resolve_symbol_edges completes with resolved 0, prefer the existing 0-edge WARN branch ("resolved 0 edges — no code symbols matched yet") over the pack-capability one; the ordering comment says pack-capability "wins", but it currently wins on unrelated evidence.
3. Update the SKILL.md wording once the classifier is fixed.