Skip to content

Add Dependency Review Action to block vulnerable dependency changes #1987

Closed

Description

@maxpetrusenkoagent

Summary

GStack has dependency-bearing manifests (package.json, bun.lock) but no pull-request dependency review gate. A PR can currently add or bump an npm/Bun dependency without a CI check that blocks newly introduced known vulnerabilities.

GitHub's current dependency review action is designed for this exact PR-time guard: it compares dependency changes in the pull request and can fail the workflow when vulnerable dependencies are introduced.

Repo-local evidence

  • origin/main has workflow files under .github/workflows/: actionlint.yml, ci-image.yml, evals.yml, evals-periodic.yml, make-pdf-gate.yml, pr-title-sync.yml, skill-docs.yml, version-gate.yml, windows-free-tests.yml, windows-setup-e2e.yml.
  • git grep -n -E 'dependency-review|osv-scanner|scorecard|ossf/scorecard|semgrep|codeql-action|github/codeql|attest-build-provenance|attestation|Dependabot' origin/main -- .github package.json bun.lock returned no matches.
  • origin/main:package.json includes runtime dependencies (@huggingface/transformers, @ngrok/ngrok, diff, marked, playwright, puppeteer-core, socks) and dev dependencies (@anthropic-ai/claude-agent-sdk, @anthropic-ai/sdk, xterm, xterm-addon-fit).
  • bun.lock is tracked on origin/main, so dependency changes have a concrete lockfile surface for PR review.
  • The repo already has a live dependency-security example: diff@7.0.0 has DoS advisory in parsePatch/applyPatch (GHSA-73rr-hh4g-fpgx) #1588 tracks diff@7.0.0 / GHSA-73rr-hh4g-fpgx, with v1.60.2.0 fix(deps): bump diff to ^9.0.0 to clear GHSA-73rr-hh4g-fpgx (#1588) #1599 opened as the bump. That kind of issue should be caught at dependency-change time, not only after a separate security review.

Expected impact

Suggested fix

Add a focused workflow, for example .github/workflows/dependency-review.yml:

GitHub docs: https://docs.github.com/en/code-security/how-tos/secure-your-supply-chain/manage-your-dependency-security/configuring-the-dependency-review-action

Duplicate check performed

Commands/files inspected

  • gh issue list --repo garrytan/gstack --state open --limit 200 --json number,title,body,url,updatedAt,labels
  • gh pr list --repo garrytan/gstack --state open --limit 200 --json number,title,body,url,updatedAt,headRefName,isDraft,labels
  • gh api --method GET search/issues -f q='<targeted query>'
  • git fetch origin main
  • git ls-tree -r --name-only origin/main .github
  • git grep -n -E 'dependency-review|osv-scanner|scorecard|ossf/scorecard|semgrep|codeql-action|github/codeql|attest-build-provenance|attestation|Dependabot' origin/main -- .github package.json bun.lock
  • git show origin/main:package.json
  • git ls-tree -r --name-only origin/main | egrep '(^|/)(bun.lockb|bun.lock|package-lock.json|pnpm-lock.yaml|yarn.lock)$'

Activity

  1. jbetala7 commented on Jun 18, 2026

    @jbetala7
    Contributor

    Opened #2038 — adds .github/workflows/dependency-review.yml using actions/dependency-review-action (fail-on-severity: high, contents: read only, ubicloud-standard-8). Validated with actionlint 1.7.12, no issues. The workflow runs on its own PR as a self-demonstration.

  2. added a commit that references this issue on Jul 13, 2026
    6fe5121
  3. capy-ai commented on Oct 2, 2026

    @capy-ai
    Contributor

    Verified on main (v1.91.13.0): .github/workflows/dependency-review.yml runs GitHub's Dependency Review Action on pull requests, so dependency changes with known vulnerabilities are blocked. Added in v1.65.0.0 (#2577). Thanks! Reply here if it misses a case and we'll reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions