gstack-memory-ingest broken on gbrain >=0.18: still calls renamed put_page subcommand #1346

Activity

1. s1dd4rth commented on May 7, 2026

   

   s1dd4rth

   on May 7, 2026

   More actions

   +1 — same failure on macOS with gbrain v0.22.8 + gstack v1.26.4.0. Adding a correction: the suggested one-line rename is incomplete.

   Environment

   • gstack 1.26.4.0
   • gbrain 0.22.8 (also reproduced on a v0.27.0 checkout before reverting)
   • macOS (Darwin 25.4.0), bun runtime

   The simple put_page -> put rename silently drops metadata

   gbrain put only accepts slug (positional) + content (stdin). The --title, --type, and --tags flags are silently consumed:

   $ echo "test body" | gbrain put gstack-test-flags --type test --tags foo,bar
   $ gbrain get gstack-test-flags
   ---
   type: concept
   title: Gstack Test Flags
   ---
   test body
   

   Type came back as auto-derived concept, tags are empty. So a literal put_page -> put swap makes calls succeed but loses all the metadata gstack built (repo:<slug>, agent:<name>, content type, etc.).

   Looking at gbrain/src/core/operations.ts:367:

   cliHints: { name: 'put', positional: ['slug'], stdin: 'content' }

   The put_page operation only takes slug and content over the CLI surface. Title/type/tags have to come from YAML frontmatter inside the body. (The put_page name itself is the operation/MCP name — it was, as far as I can tell, never a CLI subcommand. cliHints.name does the rename to put.)

   Working patch

   Rewrote gbrainPutPage() at bin/gstack-memory-ingest.ts:762 to inject metadata into the body's frontmatter (merging with existing frontmatter when present, since transcript pages already have an agent:/session_id: head):

   function gbrainPutPage(page: PageRecord): { ok: boolean; error?: string } {
     if (!gbrainAvailable()) {
       return { ok: false, error: "gbrain CLI not in PATH" };
     }
     try {
       const yamlEscape = (s: string) => JSON.stringify(s);
       const yamlList = (xs: string[]) => \`[\${xs.map(yamlEscape).join(", ")}]\`;
       const metaLines = [
         \`title: \${yamlEscape(page.title)}\`,
         \`type: \${page.type}\`,
         \`tags: \${yamlList(page.tags)}\`,
       ];
       let body: string;
       if (page.body.startsWith("---\n")) {
         const closeIdx = page.body.indexOf("\n---", 4);
         if (closeIdx > 0) {
           const existingHead = page.body.slice(4, closeIdx);
           const rest = page.body.slice(closeIdx + 4);
           body = ["---", ...metaLines, existingHead.trimEnd(), "---", rest.replace(/^\n/, "")].join("\n");
         } else {
           body = ["---", ...metaLines, "---", "", page.body].join("\n");
         }
       } else {
         body = ["---", ...metaLines, "---", "", page.body].join("\n");
       }
       execFileSync("gbrain", ["put", page.slug], {
         input: body,
         encoding: "utf-8",
         timeout: 30000,
         stdio: ["pipe", "pipe", "pipe"],
       });
       return { ok: true };
     } catch (err) {
       return { ok: false, error: err instanceof Error ? err.message : String(err) };
     }
   }

   After patch: 15 curated artifacts (CEO plans, design docs, learnings, timelines) ingested cleanly with correct types/tags preserved. gbrain list -n shows the right titles and types; semantic search ranks them as expected. 0 failed in a --bulk --sources eureka,learning,timeline,ceo-plan,design-doc,retro,builder-profile-entry run.

   Happy to send a PR if useful.
2. shelman09

   added a commit that references this issue on May 19, 2026

   test(memory-ingest): pin put_page regression + scrub stale name from …

   ...

   0472cad
3. garrytan

   closed this as completedin #1594on May 20, 2026
4. pull

   added a commit that references this issue on May 20, 2026

   v1.42.0.0 Daegu wave: 23 community-filed bugs + PTY classifier enforc…

   ...

   7ca04d8
5. adamtasteslikegood

   added a commit that references this issue on Jun 5, 2026

   merge gtan updates into adam's pi-stack fork (#5)

   ...

   b2bb301