Repository navigation
v0.51.0.0 test: pin embedding migration resume observability - #5260
Closed
Masashi-Ono0611 wants to merge 1 commit into
Closed
Masashi-Ono0611 wants to merge 1 commit into
Masashi-Ono0611 wants to merge 1 commit into
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Masashi-Ono0611
marked this pull request as ready for review
September 20, 2026 13:26
Masashi-Ono0611
marked this pull request as draft
September 20, 2026 23:23
Masashi-Ono0611
marked this pull request as ready for review
September 20, 2026 23:26
Contributor
|
Thanks for this, @Masashi-Ono0611. The test sets a |
nepalisagun
pushed a commit
to nepalisagun/gbrain
that referenced
this pull request
Oct 6, 2026
…doctor (garrytan#5260) Coverage-only: no product change, so this test cannot fail before and makes no fail-before claim. It pins that a live embedding-migration marker renders the same renderResumeCommand() output in `migrate embeddings --status --json` (resume_command), the human `--status` Resume line, and the doctor embedding-migration check. The existing suite only covered the null resume_command case. Kept: the three-channel test. Changed: the formatter output is also pinned as a literal string, so a drift in renderResumeCommand itself is caught, not only disagreement between channels. Left out: the `force_sunset_target` marker field and the `--force-sunset-target` assertion the PR description mentions. Neither the field nor the flag exists on master (`git log -S` finds no history), so there is nothing to pin. Contributed by @Masashi-Ono0611 Co-Authored-By: masashiono0611 <masashi.ono.0611@gmail.com>
nepalisagun
pushed a commit
to nepalisagun/gbrain
that referenced
this pull request
Oct 6, 2026
…tus and doctor (garrytan#5260)" This reverts commit 5de0c97.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--force-sunset-targetin the shared formatter outputValidation
bun test test/migrate-embeddings-hardening.serial.test.tsbun run typecheckbun run check:test-isolationgit diff --checkNo production logic changed. Upstream CI must be Green before this Draft is made ready for review.