#31: updates logging module to allow multiple arguments and data type…#38
Merged
Conversation
…nd data types that are not string
paulvalderama
approved these changes
Apr 24, 2020
songz
reviewed
Apr 25, 2020
| const obj = { | ||
| info: (...args) => { | ||
| args.forEach((e) => { | ||
| logger.info(JSON.stringify(e)) |
Contributor
There was a problem hiding this comment.
If I pass in 5 arguments, I wouldn't want to log 5 times. I think its better to log 1 time as a long string.
- Helper function that maps through
args. If the element type is Error, then returne.toString(). Otherwise, return the element - The helper function returns the string generated from
util.format('%j', newArray). I useutil.formatbecause I thinkJSON.stringify puts too many quotes, makes it hard to see. - Then I will just log once:
logger.info( processArgs(args) )
songz
reviewed
Apr 25, 2020
| }) | ||
| } | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
I think you should add some test to your logger.
songz
reviewed
Apr 27, 2020
|
|
||
| const obj = { | ||
| info: (...args) => { | ||
| const mappedArgs = args.map((e) => { |
Contributor
There was a problem hiding this comment.
make this a helper function:
const processArgs = (args) => {
return args.map....
}
…to loggingModule_2
allopez7
approved these changes
Apr 28, 2020
songz
requested changes
Apr 28, 2020
Contributor
songz
left a comment
songz
left a comment
There was a problem hiding this comment.
- Fix tests to have 100% code coverage
- Filename only, not the full path.
log.jsshould only be logging the filename.
songz
approved these changes
Apr 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#31: updates logging module to allow multiple arguments and data types that are not string
This update allows followings: