Open
Conversation
Signed-off-by: James Cocker <james.s.earth@gmail.com>
Signed-off-by: James Cocker <james.s.earth@gmail.com>
Signed-off-by: James Cocker <james.s.earth@gmail.com>
Signed-off-by: James Cocker <james.s.earth@gmail.com>
Signed-off-by: James Cocker <james.s.earth@gmail.com>
Signed-off-by: James Cocker <james.s.earth@gmail.com>
Signed-off-by: James Cocker <james.s.earth@gmail.com>
Signed-off-by: James Cocker <james.s.earth@gmail.com>
…hooks. Next now builds. Signed-off-by: James Cocker <james.s.earth@gmail.com>
….replace in tabs component Signed-off-by: James Cocker <james.s.earth@gmail.com>
eamansour
requested changes
Mar 18, 2026
Member
eamansour
left a comment
eamansour
left a comment
There was a problem hiding this comment.
Not too confident with these changes - added some comments and suggestions. I haven't been able to build the project locally either (I'm getting the same error that the PR workflow is getting).
galasa-ui/src/styles/global.scss
Outdated
Comment on lines
+6
to
+42
|
|
||
| // Configure Carbon feature flags to include the missing flag | ||
| @use '@carbon/styles/scss/feature-flags' with ( | ||
| $feature-flags: ( | ||
| 'enable-css-custom-properties': true, | ||
| 'enable-css-grid': true, | ||
| 'enable-v11-release': true, | ||
| 'enable-experimental-tile-contrast': false, | ||
| 'enable-tile-contrast': false, | ||
| 'enable-v12-tile-radio-icons': false, | ||
| 'enable-v12-structured-list-visible-icons': false, | ||
| 'enable-dialog-element': false, | ||
| 'enable-v12-toggle-reduced-label-spacing': false, | ||
| 'enable-presence': false, | ||
| 'enable-focus-wrap-without-sentinels': false, | ||
| ) | ||
| ); | ||
|
|
||
| // Configure font path to use fonts from public directory | ||
| @use '@carbon/styles/scss/config' with ( | ||
| $font-path: '/fonts' | ||
| ); | ||
|
|
||
| @use '@carbon/react'; | ||
| @use '@carbon/themes/scss/themes' as *; | ||
| @use '@carbon/themes'; | ||
| @use '@carbon/styles'; | ||
|
|
||
| :root { | ||
| @include themes.theme($white); /*Set default to white theme*/ | ||
| @include themes.theme($white); | ||
| /*Set default to white theme*/ | ||
| color-scheme: light; | ||
| } | ||
| @media (prefers-color-scheme: white) { | ||
|
|
||
| @media (prefers-color-scheme: dark) { | ||
| :root { | ||
| @include themes.theme($g100); /*Use dark theme for dark system preference*/ | ||
| @include themes.theme($g100); | ||
| /*Use dark theme for dark system preference*/ |
Member
There was a problem hiding this comment.
Can you explain why these changes are needed? If not, could they be reverted to avoid additional CSS changes?
Contributor
Author
There was a problem hiding this comment.
I believe the changes from lines 6-28 were due to a missing feature-flag item which was causing build issues. Whilst in the file, Bob noticed that there was a bug with @media (prefers-color-scheme: white) { as the items it included specified it should use dark mode. It's strange it wasn't causing an issue before, but I could revert th fix if you like as it doesn't change the functionality. I've placed the comments back on the same line to reduce the diff here.
Signed-off-by: James Cocker <james.s.earth@gmail.com>
Signed-off-by: James Cocker <james.s.earth@gmail.com>
Signed-off-by: James Cocker <james.s.earth@gmail.com>
Signed-off-by: James Cocker <james.s.earth@gmail.com>
Signed-off-by: James Cocker <james.s.earth@gmail.com>
…e in global.css Signed-off-by: James Cocker <james.s.earth@gmail.com>
eamansour
reviewed
Mar 30, 2026
Signed-off-by: James Cocker <james.s.earth@gmail.com>
Signed-off-by: James Cocker <james.s.earth@gmail.com>
…g akamai CDN instead of a copy script Signed-off-by: James Cocker <james.s.earth@gmail.com>
Signed-off-by: James Cocker <james.s.earth@gmail.com>
Signed-off-by: James Cocker <james.s.earth@gmail.com>
Signed-off-by: James Cocker <james.s.earth@gmail.com>
…ld, commented out webui tests for now Signed-off-by: James Cocker <james.s.earth@gmail.com>
Signed-off-by: James Cocker <james.s.earth@gmail.com>
Signed-off-by: James Cocker <james.s.earth@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Closes galasa-dev/projectmanagement#2554.
Upgrades Next.js from v14 to 16, along with some other dependencies due to high level package vulnerabilities. Made a lot of changes outside of package.json to accommodate for this upgrade. Note: a new section has been added to the
setup-locally.shscript to copy over font files to be statically served in the/publicfolder. If you have a local version running, you will need to run this script again in order to have those fonts appear as they were before the PR.Changes