Skip to content
This repository was archived by the owner on May 30, 2023. It is now read-only.

Feat: add xcm rate limit to registry#200

Closed
dmoka wants to merge 60 commits into
v0.9.38from
feat/add-xcm-rate-limit-to-registry
Closed

Feat: add xcm rate limit to registry#200
dmoka wants to merge 60 commits into
v0.9.38from
feat/add-xcm-rate-limit-to-registry

Conversation

@dmoka

@dmoka dmoka commented Apr 19, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@dmoka dmoka changed the base branch from main to v0.9.38 April 19, 2023 12:07
Comment thread asset-registry/src/lib.rs
asset_type: AssetType::Token,
existential_deposit: self.native_existential_deposit,
locked: false,
xcm_rate_limit: None,

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider adding rate limit to the genesis config.


pub(super) locked: bool,

pub(super) xcm_rate_limit: Option<Balance>,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migration will be needed. So i would take the opportunity and remove the locked field. not used for anything.

@codecov

codecov Bot commented May 8, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 94.11% and project coverage change: +0.25 🎉

Comparison is base (6649bf4) 73.91% compared to head (8363e9d) 74.17%.

❗ Current head 8363e9d differs from pull request most recent head bb58b33. Consider uploading reports for the commit bb58b33 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           v0.9.38     #200      +/-   ##
===========================================
+ Coverage    73.91%   74.17%   +0.25%     
===========================================
  Files           45       45              
  Lines         3615     3721     +106     
===========================================
+ Hits          2672     2760      +88     
- Misses         943      961      +18     
Impacted Files Coverage Δ
asset-registry/src/lib.rs 81.69% <88.88%> (+0.06%) ⬆️
asset-registry/src/benchmarking.rs 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@apopiak

apopiak commented May 29, 2023

Copy link
Copy Markdown
Contributor

close in favor of #209

@apopiak apopiak closed this May 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants