chore: upgrade polkadot v1.7.2 by enthusiastmartin · Pull Request #659 · galacticcouncil/Basilisk-node

enthusiastmartin · 2024-04-22T13:23:40Z

Notable changes

rust stable 1.75.0
orml no longer possible to import directly from github due to changes in depedencies - using fork from GC repo for now ( daniel needs to include some changes anyway). In future - use crates.io?!
Democracy - changed to generic hash instead of H256 -> chec other changes?
parachain-info reanmed to staging-parachain-info
AllPalletsReversedWithSystemFirst replaced by AllPalletsWithSystemFirst
pallet-balances no longer has transfer extrinsic
new benchmarking script

Removed

palet-xcm-rate-limiter
dmp-queue

New pallet:

pallet-message-queue - replaced dmp-queue

XCM:

xcm v4 support, we still keep v3 for
XCM - changed parameter type From Assets -> AssetInHoldings - does not use MultiAsset ( eg. in Xcm Weight Trader )
MultiAsset no longer in V4 -> replaced by AssetId(Location) type --- this changes a lot!!!
MultiLocation rename to Location in v4 -- registry migration?!! probably unecessary , it is the same type, only name change
xtokens has two new params - RateLimiter and RateLimiterId - not used atm

New config params:

Treasury - spending support, it is disabled for now
identity - bunch of new stuff, migration too

github-actions · 2024-04-22T13:26:55Z

New crates:

pallet-asset-registry: v2.3.3

Crate versions that have been updated:

runtime-integration-tests: v1.0.1 -> v1.0.2
basilisk: v11.1.0 -> v13.0.0
pallet-marketplace: v5.0.17 -> v5.0.18
pallet-xyk-liquidity-mining: v1.1.10 -> v1.1.11
pallet-xyk-liquidity-mining-benchmarking: v1.0.16 -> v1.0.17
primitives: v6.6.0 -> v6.6.1
basilisk-runtime: v112.0.0 -> v113.0.0

Runtime version has been increased.

enthusiastmartin · 2024-04-25T15:13:05Z

 	type MaxOutRatio = MaxOutRatio;
 	type OracleSource = XYKOracleSourceIdentifier;
-	type CanCreatePool = pallet_lbp::DisallowWhenLBPPoolRunning<Runtime>;
+	type CanCreatePool = hydradx_adapters::xyk::AllowPoolCreation<Runtime, AssetRegistry>;


hm.. suspicious. what happened here? double check

yeah, I think it should be fine, it has only strange naming, I changed it to also disallow specific xyk pool creation. So we do the same like in hydraDX

As I was the one who changed it, please someone else do a double check then

should be ok as we are reusing hydradx adapter

Roznovjak · 2024-04-29T12:19:04Z

 		}
 	},
-	pub struct OtherParachain {
+	pub struct OtherPara {


Let's keep naming consistent, OtherParachain

yeah I needed to find another name so I could create a helper type so we don't need to change in every tests:

pub type OtherParachain = OtherPara<TestNet>;

The struct is only used directly at this line.

dmoka · 2024-05-07T10:08:47Z


 	if let Some(hwbench) = hwbench {
 		sc_sysinfo::print_hwbench(&hwbench);
+		//TODO: need?


mrq1911 · 2024-05-07T11:46:58Z

 	type MaxOutRatio = MaxOutRatio;
 	type OracleSource = XYKOracleSourceIdentifier;
-	type CanCreatePool = pallet_lbp::DisallowWhenLBPPoolRunning<Runtime>;
+	type CanCreatePool = hydradx_adapters::xyk::AllowPoolCreation<Runtime, AssetRegistry>;


should be ok as we are reusing hydradx adapter

mrq1911 · 2024-05-07T12:02:12Z

 	type UniversalLocation = UniversalLocation;
 	type MaxAssetsForTransfer = MaxAssetsForTransfer;
 	type ReserveProvider = AbsoluteReserveProvider;
+	type RateLimiter = (); //TODO: what do ?


do we want to do something with this ratelimiter at all ? nobody else seems to be using it.

Co-authored-by: Richard Roznovjak <richardroznovjak@gmail.com>

dmoka · 2024-05-07T12:53:58Z

+#[cfg_attr(feature = "std", derive(Serialize, Deserialize))]
+pub enum AssetType<AssetId> {
+	Token,
+	PoolShare(AssetId, AssetId), // Use XYX instead


if this is deprecated, we could place attribute like

#[deprecated(since = "x.z.y", note = "Use XYK instead")]

i would not bother with this anymore. it is older version of registry. it would probably fail on clippy and we would need to allow deprecated anyway

enthusiastmartin and others added 17 commits April 12, 2024 19:10

depedencies update

c02d629

pallets configs

8fa3d26

xcm configs

eddfa4c

weights api

f67fc9f

pallets congifs

40c9cdb

pallets configs

610cff4

update node

bf15ad8

pallet test mocks

2f69611

use rococo runtime

cd82137

fix benchmark build

2b2e8a1

remove xcm rate limiter pallet

2ddb21e

use xyk from hydra

64781ca

fix compilation errors of integration tests due to new update

ea973d8

remove warnings

ea4e7d2

allo every assets for oracle

853cc13

cleaning up

20dc5cb

Add migrations

3810648

enthusiastmartin and others added 12 commits April 22, 2024 15:45

Add migrations

e1aa129

disallow xyk pool creation for share tokens

2a2cd42

fix benchmark tests

d523167

fix benchmark chainspecs

3a8b056

benchmarks weights refactor

ef2f384

use define benchmakrs

dc9ef81

add xyk benchmarks

a7d079d

add additional benchmarks

f10b03c

update benchmark script

6db66b1

fixed route executor benchmark tests

c2c3b10

add state-trie to benchmarks

eef048b

benchmakrs update

d7ce848

bump versions

784ad1a

enthusiastmartin requested review from Roznovjak, dmoka and mrq1911 April 25, 2024 15:04

enthusiastmartin marked this pull request as ready for review April 25, 2024 15:05

enthusiastmartin commented Apr 25, 2024

View reviewed changes

add src component

f6ac70e

Roznovjak reviewed Apr 29, 2024

View reviewed changes

Roznovjak reviewed Apr 30, 2024

View reviewed changes

Comment thread runtime/basilisk/src/xcm.rs Outdated

dmoka added 7 commits May 7, 2024 10:44

fix imports

7055500

simplify asset declaration

90f758a

simplify asset declaration

50b055f

rename to rococo as we don't use kusama as relay chain anymore in tests

2a528f0

add assertion for trapped event

b418893

remove unused usings

e97ca67

remove duplication

b3ac021

dmoka reviewed May 7, 2024

View reviewed changes

dmoka added 6 commits May 7, 2024 12:12

fix package version

c53ee96

renaming as we use bsx, not hdx

b172301

fix comment

1e9c157

use bsx as native asset in router benchmark

4e26854

use constant for units

aeae57f

simplify using

1b57de4

mrq1911 requested changes May 7, 2024

View reviewed changes

Update runtime/basilisk/src/xcm.rs

67f712b

Co-authored-by: Richard Roznovjak <richardroznovjak@gmail.com>

dmoka reviewed May 7, 2024

View reviewed changes

update identity's bytedeposit

b0b0e1d

mrq1911 mentioned this pull request May 7, 2024

use same XYK liquidity mining pallet as hydradx #660

Open

mrq1911 approved these changes May 8, 2024

View reviewed changes

mrq1911 merged commit 31972f1 into master May 8, 2024

Conversation

enthusiastmartin commented Apr 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dmoka May 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dmoka May 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

enthusiastmartin May 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

enthusiastmartin commented Apr 22, 2024 •

edited

Loading

github-actions Bot commented Apr 22, 2024 •

edited

Loading

dmoka May 7, 2024 •

edited

Loading

dmoka May 7, 2024 •

edited

Loading

enthusiastmartin May 7, 2024 •

edited

Loading