Skip to content

feat!: XCM Rate Limiter#636

Merged
apopiak merged 9 commits into
masterfrom
feat/xcm-rate-limit
Jul 25, 2023
Merged

feat!: XCM Rate Limiter#636
apopiak merged 9 commits into
masterfrom
feat/xcm-rate-limit

Conversation

@apopiak

@apopiak apopiak commented Jul 12, 2023

Copy link
Copy Markdown
Contributor

Add the xcm-rate-limiter pallet from galacticcouncil/hydration-node#561 to Basilisk.

Checklist:

  • I have updated the documentation if necessary.
  • I have added tests to cover my changes, regression test if fixing an issue.
  • This is a breaking change.

Todos:

  • run benchmarks and update weights

@apopiak apopiak requested review from dmoka, jak-pan and mrq1911 July 12, 2023 16:18
@github-actions

github-actions Bot commented Jul 12, 2023

Copy link
Copy Markdown

Crate versions that have been updated:

  • runtime-integration-tests: v0.9.12 -> v0.9.13
  • parachain-runtime-mock: v0.2.8 -> v0.2.9
  • basilisk-runtime: v103.0.0 -> v104.0.0

Runtime version has been increased.

type PriceForSiblingDelivery = ();
type WeightInfo = ();
type ExecuteDeferredOrigin = EnsureRoot<AccountId>;
type MaxDeferredMessages = ConstU32<100>;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happens to the messages if this buffer is filled?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrq1911 mrq1911 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix tests and LGTM

Comment thread runtime/basilisk/src/xcm.rs Outdated
@apopiak

apopiak commented Jul 14, 2023

Copy link
Copy Markdown
Contributor Author

Reason for this is that tests are run with --features runtime-benchmarks which changes the RelayChainBlockNumberProvider -.-

@codecov

codecov Bot commented Jul 17, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage has no change and project coverage change: -0.06% ⚠️

Comparison is base (fd59b6f) 49.64% compared to head (415378d) 49.59%.

❗ Current head 415378d differs from pull request most recent head 777350c. Consider uploading reports for the commit 777350c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #636      +/-   ##
==========================================
- Coverage   49.64%   49.59%   -0.06%     
==========================================
  Files          60       60              
  Lines        3857     3861       +4     
==========================================
  Hits         1915     1915              
- Misses       1942     1946       +4     
Files Changed Coverage Δ
...ntegration-tests/parachain-runtime-mock/src/lib.rs 69.04% <ø> (ø)
pallets/marketplace/src/lib.rs 90.90% <ø> (ø)
runtime/basilisk/src/lib.rs 4.79% <ø> (ø)
runtime/basilisk/src/weights/xcmp_queue.rs 0.00% <0.00%> (ø)
runtime/basilisk/src/xcm.rs 72.50% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmoka dmoka mentioned this pull request Jul 20, 2023
3 tasks
@mrq1911 mrq1911 changed the title feat!: Integrate XCM Rate Limiter feat!: XCM Rate Limiter Jul 25, 2023
@apopiak apopiak merged commit bd55c46 into master Jul 25, 2023
@jak-pan jak-pan deleted the feat/xcm-rate-limit branch February 22, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants