Repository navigation
make check deleted the Queen's live delegation registry - #301
Merged
Merged
Conversation
…rowseros-ai#1276) The gate read only the Makefile. make check drives shell scripts as well - build.sh runs tests/swift/run_chat_sse_e2e.sh at the end of a build, make e2e and the mutants rows bash it directly - so a .trinity-dev rm inside that script passed the gate untouched: the same hole as browseros-ai#1275, one level down. The gate now scans, against one forbidden list defined once in a single grep: - the cassette recipe, exactly as before, and - every tests/**/*.sh path the cassette recipe names, collected at run time, plus every script in the new ISOLATION_SCRIPTS variable, which today lists tests/swift/run_chat_sse_e2e.sh. On failure the grep prints the file and the line number of the match itself. A comment-only .trinity-dev in a script fails too, because the gate does not parse shell. The recipe body is a single sh -c block carrying no dollar sign, no backtick and no nested single quote, reading only repo-root-relative paths, so it can be lifted out between its quotes and proven with plain sh from the repo root - the worker image has no make. The dev-log needle is therefore spelled (LOG): it catches both a plain and a doubled dollar spelling of the LOG variable while carrying no dollar itself. Scans that would silently cover nothing now fail: an empty script collection (ISOLATION_SCRIPTS gone and the recipe naming no .sh), and a collected script that is not a regular file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work the Queen accepted on , closed as Trinity-S-AI-DNA/trios#1276, and never merged.\n\nMeasured 2026-09-04: 174 branches on the remote and FIVE contained in . The other 169 all carry a real diff. A closed issue whose code is not in the branch is a false statement about the repository, and the loop had been making 169 of them.\n\nMerges cleanly against the current base, checked with before this PR was opened.