Skip to content

The review cannot tell a criterion that failed from one the worker never mentioned - #179

Merged
gHashTag merged 1 commit into
feat/queen-supervisorfrom
queen-1420
Sep 4, 2026
Merged

gHashTag merged 1 commit into
feat/queen-supervisorfrom
queen-1420

Conversation

@gHashTag

@gHashTag gHashTag commented Sep 4, 2026

Copy link
Copy Markdown
Owner

Work the Queen accepted on , closed as Trinity-S-AI-DNA/trios#1420, and never merged.\n\nMeasured 2026-09-04: 174 branches on the remote and FIVE contained in . The other 169 all carry a real diff. A closed issue whose code is not in the branch is a false statement about the repository, and the loop had been making 169 of them.\n\nMerges cleanly against the current base, checked with before this PR was opened.

The six dispatches parked at the retry ceiling on 2026-09-04 all had an
unmet count that was exactly their omitted count: criteria that were
never judged at all, recorded indistinguishably from criteria that were
judged and failed. Three reached maximumRealAttempts and escalated to a
person without the work ever being assessed; the oldest waited 91 hours.

- unjudgedCriteria names the promised criteria no verdict line answered,
  matching through quote drift (punctuation, case, the parser's
  300-character slice) with a containment guard so one word cannot
  judge the whole contract.
- The round records judged and unjudged per dispatch (FR-001) and the
  send-back names the two lists under distinct headings (FR-002), so a
  worker can tell 'you did not do this' from 'you did not say whether
  you did this'.
- Once a bee has judged any criteria, the unjudged ones are added to
  the question as unmet, so the policy decides sendBack-versus-escalate
  on the complete picture rather than waiting for lines that will never
  come. A block missing entirely is still a wait: that is the torn-
  transcript signature (browseros-ai#1335), not a wall of omissions.
- An attempt whose unmet criteria are ALL unjudged does not increment
  send_backs (FR-003): the retry budget is spent on work that was
  attempted and found wanting, never on silence.

reviewFinishedDispatches is exported for the suite, as runRound is.
The new suite drives the real policy binary and pins both acceptance
scenarios: 2-of-5 judged leaves the counter alone; 5 covered with 2
failings advances it.
@gHashTag
gHashTag merged commit 0845b0b into feat/queen-supervisor Sep 4, 2026
12 of 16 checks passed
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown

❌ Tests failed — 7/1615 failed

Suite Passed Failed Skipped
✅ agent 80/80 0 0
✅ build 9/9 0 0
✅ cdp-protocol 5/5 0 0
✅ eval 93/93 0 0
✅ server-agent 262/262 0 0
❌ server-api 501/534 3 30
✅ server-browser 4/4 0 0
✅ server-integration 10/11 0 1
✅ server-lib 271/271 0 0
✅ server-root 64/64 0 0
✅ server-skills 31/31 0 0
❌ server-tools 233/237 4 0
✅ shared 14/14 0 0
Failed tests
  • server-api — the bee verdict block > takes the last block when there are two
  • server-api — the migration block, applied to a real PostgreSQL > creates every object it promises, and survives a second boot
  • server-api — the live gate > ran, or its absence is on the record
  • server-tools — navigation tools > new_hidden_page opens a hidden tab
  • server-tools — navigation tools > show_page restores a hidden page to visible
  • server-tools — window tools > create_hidden_window creates and closes a hidden window
  • server-tools — input tools > blocks coordinate-based actions with ACL intent rules

View workflow run

@gHashTag
gHashTag deleted the queen-1420 branch October 8, 2026 18:16
@gHashTag
gHashTag restored the queen-1420 branch October 8, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant