Generic Store Functions Enable Yjs - #53
Closed
jbolda wants to merge 1 commit into
Closed
Conversation
neurosnap
reviewed
Jan 4, 2025
neurosnap
left a comment
neurosnap
left a comment
Collaborator
There was a problem hiding this comment.
Overall looks good to me, but this means that yjs is the "backend" for our store and there's no ability to overlap. As long as we are fine with that idea I'm good as well.
|
|
||
| if (determineNextState?.setup) determineNextState.setup(); | ||
|
|
||
| function* updateMdw(ctx: UpdaterCtx<S>, next: Next) { |
Collaborator
There was a problem hiding this comment.
This could be a mdw that users always provide instead of forcing it to be included in the store. In that case this would reduce the default store functionality, just a thought.
Member
Author
|
The PR has become rather stale having swapped from Deno. The idea lives on, and will likely come back with renewed spirit. Closing this iteration of it until that time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP