Add conversion from Expression to Objective#13
Merged
tlambert03 merged 10 commits intofunkelab:mainfrom Apr 7, 2023
Merged
Conversation
This was referenced Mar 26, 2023
Got accidentally removed in merge conflict resolution
Member
Author
|
@funkey ... i'll take care of the cleanup here. you can just check if the general pattern looks ok |
Member
|
...too late ;) |
Member
|
Haha, I see, I missed a few more. Sorry for the noise, and thanks for cleaning up :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extends Expressions added in #9 to convert to
Objectiveobjects (with an optionalsenseargument).Note @funkey : this also changes the name of the method
constraint()toas_constraint()... (andas_objectivehere). I think it reads a bit clearer, you?