Follow up to #110: set-only mutators with enum casts

[lorenzodalaqua]

Hi, this is a follow up to my previous PR (#110) with two additional fixes I found while applying the change in production.

After merging #110, models with a set-only Attribute mutator and an enum cast on the same column still generated the database column type (string) rather than the enum type. The cast-based type resolution was being skipped entirely because ModelInspector::getCastType() returns the 'attribute' marker whenever an Attribute method exists, so the enum class name never reached WriteColumnAttribute, and the #110 fallback only looked at $attribute['type'] (the DB column type), not the model's $casts.

While testing I also discovered the fixture I added in #110 (stringWithMutatorAndNoAccessor) never actually exercised the new branch: Illuminate\Database\Eloquent\Casts\Attribute wasn't imported in Complex, so the return type resolved to the non-existent App\Models\Attribute, hasAttributeMutator() returned false, and the test silently passed while going through the wrong path. That's fixed here too.

Problems

1. A set-only Attribute mutator on a column with an enum cast generates the raw column type (string) instead of the enum type, because the 'attribute' marker from ModelInspector causes the actual cast to be ignored.
2. WriteEnumConst iterates ReflectionClass::getConstants(), which includes plain const declarations alongside enum cases. This caused a crash ("Attempt to read property 'name' on array") on any enum that also defines non-case constants (e.g. a const array of cases, common in one codebase I work on).
3. The Complex test fixture was missing the Attribute import, making the Add a fallback type for model properties with "set" only mutators #110 test a no-op.

Proposal

When no get closure is found, resolve the model's $casts before falling back to the column type. Enum class casts map to their generated const type, and scalar casts go through the normal mappings. This in theory mirrors what Eloquent does at runtime: reads on a set-only attribute still go through the model's cast.

For the WriteEnumConst crash, I suggest we filter getConstants() to only enum case instances before iterating.

I look forward to any feedback about this proposed fix and whether it fits with your vision for the package.

Changes

• src/Actions/WriteColumnAttribute.php: when the Attribute has no get closure, consult getCasts() on the model instance first, then resolve enum casts and scalar casts before falling back to the DB column type.
• src/Actions/WriteEnumConst.php: filter constants to instanceof \UnitEnum to skip non-case class constants.
• test/laravel-skeleton/app/Models/Complex.php: Add missing use Illuminate\Database\Eloquent\Casts\Attribute import, add enumWithMutatorAndNoAccessor (set-only mutator with a Roles::class cast) to cover the main fix.
• test/laravel-skeleton/database/migrations/…_create_complex_model_table.php: add the corresponding column to the table
• test/laravel-skeleton/app/Enums/Roles.php: add a NON_ADMIN_ROLES const array to exercise the WriteEnumConst fix through all existing enum tests.
• test/input/expectations/complex-model*.ts: Update the enum_with_mutator_and_no_accessor: Roles property and the Roles const block on all four expectation variants.

[lorenzodalaqua]

I see some PHPStan errors, but I believe they are pre-existing since it's not a file touched by this PR. If I am somehow mistaken please let me know.

[tcampbPPU]

hey there, let me look into the phpstan errors and see i can get those resolved on the main branch and i will look into your 2 pr, ty!

[lorenzodalaqua]

Sounds good, thanks!